Repository navigation
[v1.38] Backports 2026-11-12 - #2169
Open
jrajahalme wants to merge 3 commits into
Open
jrajahalme wants to merge 3 commits into
jrajahalme wants to merge 3 commits into
Conversation
jrajahalme
changed the title
jrajahalme
force-pushed
the
remove-destination-filter-state-v1.38
branch
4 times, most recently
from
November 13, 2026 11:01
a08480c to
b89b651
Compare
Listeners started accepting connections before the first NetworkPolicy update was installed, so connections accepted in that window had no policy for local endpoints and every request on them failed with 500 for the lifetime of the connection. The NPDS init target now becomes ready when the first policy update is installed, or after 5 seconds at most, and is shared by every listener. Signed-off-by: Mads Jon Nielsen <madsjon@gmail.com>
…on check [ upstream commit cc495ed ] SourceAddressSocketOption skips restoring the ingress (or original) source address when the upstream destination is local. The destination locality must always be determined from the actual destination address of the upstream connection. The destination filter state of the downstream connection is racy with L7 LB, as the upstream connection pool, and the socket option with it, is shared among many downstream connections. Use the remote address of the upstream socket, which Envoy sets before STATE_PREBIND options are applied. Fixes: 71e08fc ("bpf_metadata: Skip original source address for same node L7 LB destinations") Fixes: cilium/cilium#49710 Signed-off-by: Filip Grzonkowski <grzonu@gmail.com>
[ upstream commit f0ad6d1 ] Use of CiliumDestinationFilterState has been replaced with the socket destination address that Envoy always sets before setting socket options. Remove dead code no longer needed. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
jrajahalme
force-pushed
the
remove-destination-filter-state-v1.38
branch
from
November 13, 2026 14:54
b89b651 to
03f01d3
Compare
Member
Author
|
rebased to fix lint wait for image timing out |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.