Repository navigation
Conversation
javac -Xlint:all reported 20 warnings in the hand-written sources. Two parser test classes cast KeyRecordsFunction#source() to the List<Long> it already returns. The deprecated Expression constructor that takes a timestamp had @deprecated in its Javadoc but no @deprecated annotation, so its callers got no compiler warning. ASTExpression#key() returns KeyTokenSymbol<?> for the generic key() of ExpressionSymbol; javac checks that conversion at the class, so the method's own @SuppressWarnings("unchecked") had no effect. The casts are gone, the constructor carries @deprecated, and ASTExpression suppresses unchecked warnings at the class level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
javac -Xlint:allreported 20 warnings in ccl's hand-written sources. This change removes the cause of each warning that has one, and suppresses the one that a signature requires.Behavior
Expression(TimestampSymbol, KeySymbol, OperatorSymbol, ValueSymbol...)carries@Deprecated, as its Javadoc already stated, so code that calls it now gets a compiler deprecation warning.ASTExpressionsuppresses unchecked warnings at the class level. Itskey()returnsKeyTokenSymbol<?>for the generickey()ofExpressionSymbol, and javac checks that conversion at the class, so a suppression on the method has no effect.CompilerJavaCCLogicTestandJavaCCParserLogicTestassert the same values without castingKeyRecordsFunction#source()to theList<Long>it already returns.