Skip to content

feat(stack-kms-vault): HashiCorp Vault Transit key vendor backend (CIP-5310) - #1529

Draft
freshtonic wants to merge 6 commits into
james/cip-5307-aws-kms-key-vendor-backend-stack-kms-awsfrom
james/cip-5310-hashicorp-vault-transit-key-vendor-backend-stack-kms-vault
Draft

freshtonic wants to merge 6 commits into
james/cip-5307-aws-kms-key-vendor-backend-stack-kms-awsfrom
james/cip-5310-hashicorp-vault-transit-key-vendor-backend-stack-kms-vault

Conversation

@freshtonic

@freshtonic freshtonic commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Layer 6 of the CIP-5203 stack. Implements CIP-5310.

  • New crate stack-kms-vault: a Transit client that uses batch_input, so wrapped data key mode sends one call per chunk of 250 keys. It supports both key modes.
  • stack_kms_vendor::bound binds the AAD into the wrapped key itself. Vault ignores context on a key that is not derived, and Azure (CIP-5309) needs the same mechanism.
  • Auth: token, AppRole, and Kubernetes (native only).
  • Tests: recorded fixtures, the contract suite, and a vault server -dev CI job.
  • The crate is staged in the stack-kms-vendor release group.

Decisions are in docs/plans/2026-11-05-key-vendor-backends-decisions.md (CIP-5310 sections).

@changeset-bot

changeset-bot Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0642192

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

@freshtonic freshtonic changed the title james/cip 5310 hashicorp vault transit key vendor backend stack kms vault feat(stack-kms-vault): HashiCorp Vault Transit key vendor backend (CIP-5310) Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Mutation testing (cargo-mutants, --in-diff, stack-auth + stack-encrypt)

caught missed unviable timeout
60 0 94 0

Every mutant in the changed lines was caught by a test.

@freshtonic
freshtonic added this pull request to stack #1523 November 6, 2026 00:26
@freshtonic
freshtonic force-pushed the james/cip-5310-hashicorp-vault-transit-key-vendor-backend-stack-kms-vault branch from 37aebb1 to bfdd74a Compare November 6, 2026 02:15
@freshtonic
freshtonic force-pushed the james/cip-5310-hashicorp-vault-transit-key-vendor-backend-stack-kms-vault branch from bfdd74a to 95da1a1 Compare November 6, 2026 05:10
…5310)

The HashiCorp Vault Transit backend uses batch calls. It supports token,
AppRole and Kubernetes auth.
Add recorded Vault fixtures, the contract suite over a Transit emulator
and a vault server -dev test.
Check the WASI build. Stage the crate for crates.io.
@freshtonic
freshtonic force-pushed the james/cip-5310-hashicorp-vault-transit-key-vendor-backend-stack-kms-vault branch from 95da1a1 to 0642192 Compare November 6, 2026 05:13

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant