Skip to content

feat(stack-kms-gcp): Google Cloud KMS key vendor backend (CIP-5308) - #1530

Draft
freshtonic wants to merge 5 commits into
james/cip-5310-hashicorp-vault-transit-key-vendor-backend-stack-kms-vaultfrom
james/cip-5308-google-cloud-kms-key-vendor-backend-stack-kms-gcp
Draft

freshtonic wants to merge 5 commits into
james/cip-5310-hashicorp-vault-transit-key-vendor-backend-stack-kms-vaultfrom
james/cip-5308-google-cloud-kms-key-vendor-backend-stack-kms-gcp

Conversation

@freshtonic

@freshtonic freshtonic commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Layer 7 of the CIP-5203 stack. Implements CIP-5308.

  • New crate stack-kms-gcp: a Cloud KMS REST client (encrypt/decrypt) that supports both key modes. Data keys are generated locally, the AAD goes in additionalAuthenticatedData, and CRC32C is checked on every field.
  • Credentials: a static token, a service account JWT (RS256 with the rsa crate), and the metadata server (native only).
  • Tests: hand-written fixtures, a JWT known-answer test against openssl, and the contract suite.
  • The opt-in live workflow is integration-gcp-kms.yml. To turn it on, set the variable STACK_KMS_GCP_LIVE_KEY and the secret STACK_KMS_GCP_SERVICE_ACCOUNT_KEY.
  • Before release: a security reviewer must sign off on RUSTSEC-2023-0071 (rsa). See the orchestrator review in the decision log.

@freshtonic
freshtonic added this pull request to stack #1523 November 6, 2026 00:26
@freshtonic freshtonic changed the title james/cip 5308 google cloud kms key vendor backend stack kms gcp feat(stack-kms-gcp): Google Cloud KMS key vendor backend (CIP-5308) Nov 6, 2026
@coderabbitai

coderabbitai Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

@changeset-bot

changeset-bot Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 5663ebf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Mutation testing (cargo-mutants, --in-diff, stack-auth + stack-encrypt)

caught missed unviable timeout
60 0 94 0

Every mutant in the changed lines was caught by a test.

@freshtonic
freshtonic force-pushed the james/cip-5308-google-cloud-kms-key-vendor-backend-stack-kms-gcp branch from 1d6b20b to fb22d06 Compare November 6, 2026 02:15
@freshtonic
freshtonic force-pushed the james/cip-5308-google-cloud-kms-key-vendor-backend-stack-kms-gcp branch from fb22d06 to 73a5153 Compare November 6, 2026 05:10
The Google Cloud KMS backend checks CRC32C values. It supports service
account and metadata server credentials.
Add Cloud KMS fixtures, an openssl JWT known answer, the contract suite
over a Cloud KMS emulator and a live test.
Check the WASI build. Stage the crate for crates.io.
@freshtonic
freshtonic force-pushed the james/cip-5308-google-cloud-kms-key-vendor-backend-stack-kms-gcp branch from 73a5153 to 5663ebf Compare November 6, 2026 05:13

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant