Repository navigation
test(stack-kms-azure): name the fixture AES key the vendor key - #1555
Draft
freshtonic wants to merge 1 commit into
Draft
freshtonic wants to merge 1 commit into
freshtonic wants to merge 1 commit into
Conversation
The emulator's AES key-wrap helpers called the key a KEK. CONTEXT.md lists KEK as a term to avoid: the vendor key is the key that wraps. Rename TEST_ONLY_KEK to TEST_ONLY_VENDOR_KEY and the kek parameters to vendor_key.
|
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test-only rename. The Azure Key Vault emulator in the tests called its AES wrapping key a "KEK". The project glossary (
packages/stack-encrypt/CONTEXT.md) lists KEK as a term to avoid, because in this design the vendor key is the key that wraps. No behaviour changes.Changes
packages/stack-kms-azure/tests:TEST_ONLY_KEKis nowTEST_ONLY_VENDOR_KEY, and thekekparameters arevendor_key.Verification
mise x --env test -- cargo nextest run -p stack-kms-azure --all-features: 57 of 57 pass.cargo clippy -p stack-kms-azure --all-features --all-targets -- -D warningsandcargo fmt --check: pass.Related
Refs #1541 (the PR below this one in the stack). Code-smell follow-up to the key vendor backend stack.