Repository navigation
fix(auth): take the backend names that stash keyset prints - #1559
Draft
freshtonic wants to merge 1 commit into
Draft
freshtonic wants to merge 1 commit into
freshtonic wants to merge 1 commit into
Conversation
keysetCreate took "aws" as the backend, but its result named the same backend "aws-kms". A value from the output was not a valid input, and the error message wrote the list of short names again by hand. The input now takes both the short name and the full name (KeyVendor::name). One table holds the short names, and the error message comes from that table. The short names still work, so no command line or skill example breaks. The stash CLI checks --backend before it calls the binding, so it takes the full names too, from one map of short name to full name. The --backend help and the stash-cli skill say so.
🦋 Changeset detectedLatest commit: 14c97af The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stash keyset createtook the backend asawsbut printed it asaws-kms. A value from the output was not a valid input. The error message also wrote out the list of short names again by hand. Now both the short names and the full names work, and each side takes its list and its error text from one table.Changes
@cipherstash/auth(keyset.rs): takes the short name or the full name (KeyVendor::name). The error message comes from theBACKENDStable.native.d.tsrebuilt (only a doc comment changed).stashCLI:--backendtakes the full names too, from one map (KEYSET_BACKEND_NAMES). The--backendhelp text says so.skills/stash-cli/SKILL.md: updated.@cipherstash/authandstashpatch.Behaviour change
--backend aws-kms,gcp-kms,azure-key-vaultandvault-transitare now accepted. The short names still work, so no command line or skill example breaks.Verification
Run on the top branch of this stack (
james/kms-vendor-dispatch), on macOS:cargo fmt --all --checkandcargo clippy --workspace --all-features --all-targets -- -D warnings: pass.mise x --env test -- cargo nextest run --workspace --all-features: 1401 of 1402 pass. The one failure isstack-encrypt::ui derive_diagnostics(trybuild). It fails on every snapshot because of a local rustc wrapper that changes the paths in the compiler output. This stack does not touchstack-encrypt. CI is the check for it.mise run wasm:guest:test: 80 of 80 pass.go vet ./...andgo test -count=1 ./...inlanguages/golang: pass.pnpm --filter @cipherstash/auth test: 92 pass.pnpm --filter stash test: 1667 pass.cargo checkof the workspace and the guest (native andwasm32-wasip1) on each branch of the stack: pass.Related
Refs #1541. Code-smell follow-up to the key vendor backend stack.