Skip to content

chore(ui): Increase retries and timeout in CI - #9969

Merged
dstaley merged 4 commits into
mainfrom
ds.fix/vitest-retry-timeout
Sep 28, 2026
Merged

dstaley merged 4 commits into
mainfrom
ds.fix/vitest-retry-timeout

Conversation

@dstaley

@dstaley dstaley commented Sep 28, 2026

Copy link
Copy Markdown
Member

Description

This PR increases the retries and timeout in CI for @clerk/ui unit tests. This is to (hopefully!) alleviate flaky tests when run in a CI environment. It also hardcodes the Turborepo concurrency to 1 for unit tests, which ensures that only one package's unit tests are running at a time. This is due to the fact that our unit test runner (Vitest) already distributes tests across available cores; with multiple packages running at once, we are potentially running a large number of concurrent tests.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-bot Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e7271a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Sep 28, 2026 8:06pm UTC
swingset Ready Ready Preview Sep 28, 2026 8:06pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Team

Run ID: b9a3a33e-23fa-44a7-8711-e83883b9df46

📥 Commits

Reviewing files that changed from the base of the PR and between f190116 and e7271a5.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. 7 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.


📝 Walkthrough

Walkthrough

The CI workflow sets the first numeric --concurrency option in TURBO_ARGS to 1 before either unit-test path. In CI, Vitest retries failed tests up to three times and uses a 10-second timeout. Outside CI, Vitest disables retries and uses a 5-second timeout. The changeset file contains two delimiter lines with no content between them.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: alexcarpenter

Merge Risk: ⚪ Minimal · up to e7271

The CI test-setting changes are mergeable after normal checks; no concrete issue remains identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the primary change: increased CI retries and timeout for UI tests. It does not mention the concurrency change, but the title does not need to cover every detail.
Description check ✅ Passed The description directly explains the increased CI retries and timeout and the Turborepo concurrency change. It is related to the changeset and provides sufficient context.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-09-28T20:07:08.304Z

Summary

Metric Count
Packages analyzed 19
Packages with changes 0
🔴 Breaking changes 0
🟡 Non-breaking changes 0
🟢 Additions 0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on e7271a5.

@pkg-pr-new

pkg-pr-new Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9969

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9969

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9969

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9969

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9969

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9969

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9969

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9969

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9969

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9969

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9969

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9969

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9969

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9969

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@9969

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9969

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9969

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9969

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9969

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9969

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9969

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9969

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9969

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9969

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9969

commit: e7271a5

@dstaley
dstaley merged commit 018aa95 into main Sep 28, 2026
52 checks passed
@dstaley
dstaley deleted the ds.fix/vitest-retry-timeout branch September 28, 2026 21:12

This branch was successfully deployed

2 active deployments
Preview – swingset — e7271a58 Deployed Sep 28, 2026 by vercel[bot]
Preview – clerk-js-sandbox — e7271a58 Deployed Sep 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants