[Geliogabalus]

Description

Makes the private pin() factory public, with three options:

paper.options.connectionStrategy = connectionStrategies.pin({
    relative: true,          // percentages (pinRelative) or pixels (pinAbsolute)
    useModelGeometry: true,  // measure the model bbox; the created anchor gets `useModelGeometry: true` too
    clamp: true              // a point outside the element is moved onto its edge
});

• useModelGeometry measures element.getBBox(), or element.getPortBBox(port) when the end has a port. It undoes the rotation around that box's center. The topLeft anchor with useModelGeometry and rotate: true uses the same box and pivot, so the anchor resolves to the dropped point.
• clamp limits the offsets to [0, width] × [0, height].
• pinAbsolute and pinRelative are now pin() and pin({ relative: true }) and behave as before. The strategy no longer rotates the passed coords in place.
• Link-to-link ends ignore useModelGeometry and clamp, because the closest point on a connection already lies on it.

Fixes #3531

Motivation and Context

pinRelative / pinAbsolute measure the rendered node under the pointer. An app whose anchors use useModelGeometry gets offsets computed for one box and applied to another. With snapLinks, an end dropped next to an element is also stored outside it, so it floats beside the element and drifts away when the element is resized. Today an app has to write its own strategy to work around this.

Tests

• test/jointjs/linkView.js adds a pin() module. It covers the defaults, relative, clamp, useModelGeometry on a label magnet and on a port, and that coords are left unchanged. A round-trip test on a rotated element checks that the anchor resolves back to the dropped point for every combination of relative and useModelGeometry.
• test/ts/shapes.test.ts adds a typings check.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.