Repository navigation
Conversation
…g timezones client-side Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
A lot of customers are still on CLI v1, so can we apply this change to v1 as well? Here is the process to apply the change to both versions: https://cloudbees.atlassian.net/wiki/x/u4FcUAE |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The CLI resolves JUnit
<testsuite timestamp>timezones itself with a blankettzlocal(). That's correct for offset-aware and genuinely-local frameworks, but wrong for "looks-naive-but-UTC" runners (jest, cypress), corruptingtest_cases.created_aton non-UTC agents and breaking cross-machine elapsed-time aggregation (AIENG-379, Option 2). Mirroring the framework-timezone policy in every client is also unmaintainable.What
Move timezone resolution to the server (single source of truth). The CLI now:
<testsuite timestamp>string assuiteTimestamp(unresolved);record testsrequest (agentUtcOffset) — only the client knows it, and the server needs it to resolve naive local timestamps._timestamp()/tzlocal()and the framework-TZ imports are removed — the CLI holds zero timezone knowledge. Requires the paired mothership change that accepts these fields and resolves them.Tests
Full suite green except one pre-existing, unrelated subset failure (
test_maven.test_scan_test_compile_lst, fails on clean main). Updated golden payloads to the raw-passthrough format; comparator now excludes the machine-dependentagentUtcOffset.