Repository navigation
Enhancement/lchib 614 fix nested maven test scenario cli v2 - #1415
Merged
jothikumar-CB merged 5 commits intoOct 26, 2026
Merged
jothikumar-CB merged 5 commits into
jothikumar-CB merged 5 commits into
Conversation
Release for v1.125.3
…-nested-maven-test-scenario enhancement/LCHIB-614: fix nested maven test usecase
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The central counting correction needs regression tests that distinguish separate testcases with identical paths from retries of one testcase.
1 open issue
What changed in this PR
This PR corrects CLI test-summary counting for nested Maven tests whose canonical paths collide, while keeping retry attempts grouped as one test.
Changes:
- Assign an internal batch ID to events from each original JUnit testcase.
- Group summaries by batch ID, falling back to complete path attributes for other runners.
- Remove internal batch IDs before uploading events.
| File | Description |
|---|---|
smart_tests/commands/record/tests.py |
Updates summary grouping and strips batch IDs from upload payloads. |
smart_tests/commands/record/case_event.py |
Assigns a shared batch ID to each testcase’s attempt events. |
Review effort: Balanced
ItIsUday
approved these changes
Oct 26, 2026
mnamachivayam
approved these changes
Oct 26, 2026
jothikumar-CB
deleted the
enhancement/LCHIB-614-fix-nested-maven-test-scenario-cli-v2
branch
October 26, 2026 09:31
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Uh oh!
There was an error while loading. Please reload this page.