Repository navigation
AIENG-379: forward-port v1 → main — server-owned timezone resolution - #1417
Merged
Merged
Conversation
…g timezones client-side Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…void clash with ST test suite) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ption2-v1 AIENG-379: stop resolving timezones client-side; send raw suite timestamp + agent offset
Release for v1.125.4
…ed-build-option2-main # Conflicts: # launchable/commands/record/tests.py # smart_tests/commands/record/case_event.py
ono-max
approved these changes
Oct 29, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Forward-port of the v1 fix (#1413) to
main, per the v1→main process. The CLI resolved JUnit<testsuite timestamp>timezones itself with a blankettzlocal()— wrong for "looks-naive-but-UTC" runners (jest, cypress) on non-UTC agents, corrupting elapsed-time aggregation (AIENG-379). The CLI now sends the raw timestamp and the server resolves it.What
git merge v1, with thelaunchable/→smart_tests/rename conflicts resolved (kept main'sstr | Nonestyle andsmart_tests/SMART_TESTS_TOKENconventions, applied v1's logic). The CLI:<testsuite timestamp>asjunitSuiteTimestamp(the field was renamed on v1 to avoid clashing with the Smart Tests "test suite" concept);agentUtcOffsetonce perrecord testsrequest;_timestamp/tzlocalremoved).Tests
Full suite green except the pre-existing, unrelated
test_maven.test_scan_test_compile_lstsubset failure. Lint clean.Coordination
Pairs with mothership #14576, which must use the same wire field name
junitSuiteTimestamp(currentlysuiteTimestampthere) — being updated to match.