Repository navigation
fix(ci): Do not fail build on false-positive stringop-overflow warning - #549
Merged
Merged
Conversation
The code in question is `left_encode` in `boringssl/crypto/fipsmodule/keccak/keccak.cc.inc`. Both me and the clanker audited it and found no issue, while `stringop-overflow` has a long list of false positives reported against it: - <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92955> - <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94335> - <https://issues.chromium.org/issues/42290598> - <https://bugs.launchpad.net/ubuntu/+source/gcc-12/+bug/2013140> - <https://bugzilla.redhat.com/show_bug.cgi?id=2432481> We could probably fix the warning by rewriting the function, but IMO the overhead of carrying a patch is not justified for a false-positive GCC lint. By setting `-Wno-error=stringop-overflow` the warning will still be reported but not fail the CI build anymore.
![clanky-the-clanker[bot]](https://avatars.githubusercontent.com/in/5306670?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Approved — The change to CI warning flags is small and well explained. No issues found.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
📋 Code Quality: ✅ LGTM
The CI change only stops the stringop-overflow warning from failing the build. The warning is still reported. No issues found.
Reviewed commit: 7f9cefeb
Contributor
Author
|
Warning is still reported without failing the build: https://github.com/cloudflare/boring/actions/runs/41839521063/job/126607069365?pr=549#step:7:387 |
fisherdarling
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code in question is
left_encodeinboringssl/crypto/fipsmodule/keccak/keccak.cc.inc. Both me and the clanker audited it and found no issue, whilestringop-overflowhas a long list of false positives reported against it:We could probably fix the warning by rewriting the function, but IMO the overhead of carrying a patch is not justified for a false-positive GCC lint. By setting
-Wno-error=stringop-overflowthe warning will still be reported but not fail the CI build anymore.See #548 for CI runs that fail because of this.