Repository navigation
Fix crates.io release dispatch requests - #551
Conversation
Crates.io release dispatches accept versions with an optional `v` prefix and normalize the value before validation and publishing. Requests to the crates.io API and sparse index carry a descriptive `User-Agent`, avoiding the 403 response that blocked the production `boring-sys` publish preflight.
There was a problem hiding this comment.
✅ Approved — The version normalization and User-Agent changes are correct, and every later step uses the normalized version. No issues found.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
📋 Code Quality: ✅ LGTM
EXPECTED_VERSION="${EXPECTED_VERSION#v}" runs before the semver check. The normalized value is passed on as a step output and a job output, and both the verify step and the publish job read it from there. --user-agent is added to all three crates.io curl calls. The job-level EXPECTED_VERSION still holds the raw input, but every step that reads the variable sets its own value in step-level env, so the raw value is never used.
📝 Documentation: ✅ LGTM
The release instructions in the README say to enter the version without the v prefix. That still works with this change, so the instructions remain accurate.
Reviewed commit: de8c2e71
Crates.io release dispatches accept versions with an optional
vprefix and normalize the value before validation and publishing. Requests to the crates.io API and sparse index carry a descriptiveUser-Agent, avoiding the 403 response that blocked the productionboring-syspublish preflight.