Skip to content

Fix crates.io release dispatch requests - #551

Merged
dotjs merged 1 commit into
masterfrom
nox/publish-process-fixes
Nov 6, 2026
Merged

dotjs merged 1 commit into
masterfrom
nox/publish-process-fixes

Conversation

@nox

@nox nox commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Crates.io release dispatches accept versions with an optional v prefix and normalize the value before validation and publishing. Requests to the crates.io API and sparse index carry a descriptive User-Agent, avoiding the 403 response that blocked the production boring-sys publish preflight.

Crates.io release dispatches accept versions with an optional `v` prefix
and normalize the value before validation and publishing. Requests to the
crates.io API and sparse index carry a descriptive `User-Agent`, avoiding the
403 response that blocked the production `boring-sys` publish preflight.

@clanky-the-clanker clanky-the-clanker Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved — The version normalization and User-Agent changes are correct, and every later step uses the normalized version. No issues found.

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

📋 Code Quality: ✅ LGTM

EXPECTED_VERSION="${EXPECTED_VERSION#v}" runs before the semver check. The normalized value is passed on as a step output and a job output, and both the verify step and the publish job read it from there. --user-agent is added to all three crates.io curl calls. The job-level EXPECTED_VERSION still holds the raw input, but every step that reads the variable sets its own value in step-level env, so the raw value is never used.


📝 Documentation: ✅ LGTM

The release instructions in the README say to enter the version without the v prefix. That still works with this change, so the instructions remain accurate.


Reviewed commit: de8c2e71

@dotjs
dotjs merged commit 5596e0f into master Nov 6, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants