Repository navigation
feat(workflows): migrate cut-release and goreleaser to shared release workflows - #86
Open
onuryilmaz wants to merge 1 commit into
Open
onuryilmaz wants to merge 1 commit into
onuryilmaz wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Tag pushes using GITHUB_TOKEN cannot trigger binary publishing, and the explicit dispatch fallback was removed.
1 open finding
What changed in this PR
Migrates cloudctl’s release automation to shared workflows in cloudoperators/common.
Changes:
- Delegates version bumping and release creation to
shared-release.yaml. - Delegates binary publishing to
shared-goreleaser.yaml. - Sets a static Makefile version managed by release automation.
| File | Description |
|---|---|
| Makefile | Replaces git-derived VERSION with 2.0.1. |
| .github/workflows/release.yaml | Calls the shared GoReleaser workflow. |
| .github/workflows/cut-release.yaml | Calls the shared release workflow with bump input and token. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
… workflows Signed-off-by: I313226 <I313226@users.noreply.github.com>
onuryilmaz
force-pushed
the
feat/phase1-use-shared-release-workflows
branch
from
October 15, 2026 14:48
316fd74 to
5d13610
Compare
Contributor
Author
|
@copilot review |
1 similar comment
Contributor
Author
|
@copilot review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the bespoke version-bump and binary-release workflows with callers of shared reusable workflows from
cloudoperators/common.Changes
cut-release.yaml: replaced the bespoke semver-bump-and-tag logic with a call tocloudoperators/common/shared-release.yaml. The shared workflow handles version computation, Makefile update, git commit, tag push, and GitHub Release creation — all in one place.release.yaml: replaced the inline GoReleaser steps with a call tocloudoperators/common/shared-goreleaser.yaml.Makefile: replacedVERSION ?= $(shell git describe --tags ...)with a staticVERSION ?= 2.0.1. The shared-release workflow now owns version bumping viased— the git-describe approach is superseded. The value is updated automatically on each release.Behaviour changes
cut-release.yamlnow also creates a GitHub Release (previously it only created a tag and triggeredrelease.yamlseparately). The two steps are unified inshared-release.yaml.~> v2(unchanged from before).Test plan
cut-releaseworkflow runs with patch/minor/major bump and correctly updates Makefile VERSION, commits, tags, and creates a GitHub Releaserelease.yamltriggers on av*tag push and GoReleaser successfully builds and attaches binariescloudoperators/common@mainbefore merging