Repository navigation
feat(ui): add appearance="buttons" to TabBar and rename "main" to "tabs" - #2081
Merged
Merged
Conversation
…#2028) - Add appearance="buttons" for a pill-style segmented control - Add appearance="tabs" as new canonical name (replaces "content") - Keep appearance="content" as deprecated functional alias with console.warn - Preserve appearance="main" as default (unchanged) - Add CSS tokens for buttons appearance in theme.css and global.css - Hide deprecated tabStyle prop from Storybook Controls Signed-off-by: MartinS-git <info@eyepic.de>
🦋 Changeset detectedLatest commit: 884a115 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
MartinS-git
changed the title
This was referenced Oct 12, 2026
…nct variant - Default changes from "main" to "tabs" - "main" is now a deprecated alias of "tabs" with console.warn - "content" remains a distinct style variant (no longer deprecated) - Update stories, tests, and changeset accordingly Signed-off-by: MartinS-git <info@eyepic.de>
Signed-off-by: MartinS-git <info@eyepic.de>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Disabled items retain an interactive hover state, and the new visual branches lack effective regression assertions.
3 open findings
What changed in this PR
Adds the buttons TabBar appearance while introducing tabs as the default and deprecating main.
Changes:
- Adds segmented-button styling and theme tokens.
- Preserves deprecated TabNavigation compatibility.
- Adds stories, tests, and release notes.
| File | Description |
|---|---|
.changeset/tabbar-appearance.md |
Documents the minor release. |
packages/ui-components/src/theme.css |
Adds TabBar button theme tokens. |
packages/ui-components/src/global.css |
Adds corresponding global tokens. |
packages/ui-components/src/index.ts |
Exports the deprecated appearance type. |
packages/ui-components/src/components/TabBar/TabBar.component.tsx |
Adds appearances, defaults, styling, and warnings. |
packages/ui-components/src/components/TabBar/TabNavigation.deprecated.tsx |
Preserves the legacy default appearance. |
packages/ui-components/src/components/TabBar/TabBar.stories.tsx |
Documents all appearance variants. |
packages/ui-components/src/components/TabBar/TabBar.test.tsx |
Tests appearance selection and warnings. |
packages/ui-components/src/components/TabBarItem/TabBarItem.component.tsx |
Adds button and content item styling. |
packages/ui-components/src/components/TabBarItem/TabBarItem.test.tsx |
Tests item appearance classes. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
MartinS-git
marked this pull request as ready for review
October 12, 2026 08:54
Signed-off-by: MartinS-git <info@eyepic.de>
franzheidl
changed the title
franzheidl
previously approved these changes
Oct 13, 2026
franzheidl
left a comment
franzheidl
left a comment
Member
There was a problem hiding this comment.
I have left two comments re things I think we should improve, no blockers though.
Member
|
Also, the parent element that supplies the background color appears to be block level and consume all the available horizontal space. This needs to be chnaged to only cover the horizontal space that is actually needed by the button-like elements. |
- Fix double warning: TabNavigation no longer triggers the appearance="main" deprecation warning. useEffect now checks the raw appearance prop. - Rename internal *Tabs* variables to *Content* to match the appearance they style. - Add jn:w-fit to buttons appearance so it no longer spans full container width. - Reorder appearance control options in stories: tabs -> content -> buttons. Signed-off-by: MartinS-git <info@eyepic.de>
Signed-off-by: MartinS-git <info@eyepic.de>
franzheidl
previously approved these changes
Oct 14, 2026
Signed-off-by: MartinS-git <info@eyepic.de>
…es in TabBar Swap bracket-value classes for standard Tailwind utilities with identical computed CSS: rounded-sm, p-0.5, py-3.5, px-6.25, px-2.5, py-1.75. Signed-off-by: MartinS-git <info@eyepic.de>
edda
approved these changes
Oct 14, 2026
franzheidl
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2028.
Summary
appearance="buttons"toTabBar, a pill-style segmented control for pre-defined filter use cases like inDataGridappearance="main"toappearance="tabs"."tabs"is now the default.appearance="main"keeps working as a deprecated alias and emits aconsole.warnon first use. Switch toappearance="tabs".appearance="content"remains a distinct style variant with a shared bottom border (unchanged)buttonsappearance totheme.cssandglobal.cssStorybook
TabsAppearance,ButtonsAppearance,ContentAppearanceMainAppearance, now showing the deprecated"main"variant with a deprecation notetabStyleprop hidden from Storybook Controls (table: { disable: true }). It is a deprecated backwards-compat alias forTabNavigationand not intended for direct use. Useappearanceinstead.Notes
The
appearance="buttons"variant has previously been prototyped as a standalone component in PR #2020. That PR should be closed and its branch deleted once this one is merged.tabStyleandTabNavigationare marked deprecated in code and can be removed in a future major release once no consumers depend on them.