Skip to content

chore(deps): upgrade dependencies and fix monorepo architecture - #2086

Merged
ArtieReus merged 3 commits into
mainfrom
arite-fix-immer-react-query-dependency
Oct 13, 2026
Merged

ArtieReus merged 3 commits into
mainfrom
arite-fix-immer-react-query-dependency

Conversation

@ArtieReus

@ArtieReus ArtieReus commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

This PR upgrades multiple dependencies to their latest patch versions and fixes monorepo architecture issues by ensuring all dependencies are explicitly declared where they are used, rather than relying on hoisting or incorrect root dependencies.

Changes Made

Dependency Upgrades (Patch Versions)

  • @tanstack/react-query: 5.104.0 → 5.104.1 (4 apps)
  • immer: 11.1.18 → 11.1.21 (greenhouse, supernova)
  • jsdom: 30.1.1 → 30.1.2 (4 apps + 8 packages)
  • vite-plugin-dts: 5.1.1 → 5.1.2 (8 packages)
  • @vitejs/plugin-react: 6.1.1 → 6.1.2 (5 apps + ui-components)
  • typescript-eslint: 8.71.0 → 8.71.1 (config package)

Architecture Fixes

  • Removed unnecessary dependencies from root package.json:

    • Removed @tanstack/react-query@5.103.1 (production deps should not be in monorepo root)
    • Removed zod@4.6.5 (production deps should not be in monorepo root)
  • Fixed missing explicit dependencies (were relying on hoisting):

    • Added zod@4.6.5 to: apps/doop, apps/heureka, apps/supernova
    • Added jsdom@30.1.2 to: packages/greenhouse-auth-provider, packages/k8s-client, packages/messages-provider, packages/oauth
  • Removed redundant dependency:

    • Removed postcss@8.5.28 from apps/heureka (Vite provides it internally)

Related Issues

Screenshots (if applicable)

N/A - No visual changes

Testing Instructions

  1. pnpm install
  2. pnpm build - Verify all packages build successfully
  3. pnpm test - Verify all tests pass (1,734 tests)
  4. pnpm lint - Verify linting passes
  5. pnpm typecheck - Verify TypeScript compilation
  6. pnpm check-format - Verify code formatting

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Copilot AI balanced review requested due to automatic review settings October 13, 2026 06:50
@ArtieReus
ArtieReus requested review from a team and franzheidl as code owners October 13, 2026 06:50
@ArtieReus ArtieReus self-assigned this Oct 13, 2026
@changeset-bot

changeset-bot Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: dcd95e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-13 07:19 UTC

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Greenhouse still relies on an undeclared jsdom dependency for its Vitest environment.

1 open finding
What changed in this PR

Upgrades patch dependencies and improves workspace dependency declarations.

Changes:

  • Updates React Query, jsdom, Immer, Vite tooling, and TypeScript ESLint.
  • Moves runtime dependencies from the root to consuming apps.
  • Adds missing jsdom declarations and removes redundant PostCSS.
File Description
package.json Removes root runtime dependencies.
pnpm-lock.yaml Records dependency and workspace changes.
apps/​doop/​package.json Updates tooling and adds Zod.
apps/​greenhouse/​package.json Updates React Query, Immer, and React tooling.
apps/​heureka/​package.json Updates dependencies, adds Zod, and removes PostCSS.
apps/​supernova/​package.json Updates dependencies and adds Zod.
apps/​template/​package.json Updates React and jsdom tooling.
packages/​communicator/​package.json Updates jsdom and declaration tooling.
packages/​config/​package.json Updates TypeScript ESLint.
packages/​greenhouse-auth-provider/​package.json Adds jsdom and updates declaration tooling.
packages/​k8s-client/​package.json Adds jsdom and updates declaration tooling.
packages/​messages-provider/​package.json Adds jsdom and updates declaration tooling.
packages/​oauth/​package.json Adds jsdom and updates declaration tooling.
packages/​template/​package.json Updates jsdom and declaration tooling.
packages/​ui-components/​package.json Updates Vite, React, and jsdom tooling.
packages/​url-state-provider/​package.json Updates jsdom and declaration tooling.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread apps/greenhouse/package.json
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
@ArtieReus
ArtieReus merged commit 68c0861 into main Oct 13, 2026
25 checks passed
@ArtieReus
ArtieReus deleted the arite-fix-immer-react-query-dependency branch October 13, 2026 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants