Repository navigation
chore(deps): upgrade dependencies and fix monorepo architecture - #2086
Conversation
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
|
|
There was a problem hiding this comment.
🟡 Changes recommended
Greenhouse still relies on an undeclared jsdom dependency for its Vitest environment.
1 open finding
What changed in this PR
Upgrades patch dependencies and improves workspace dependency declarations.
Changes:
- Updates React Query, jsdom, Immer, Vite tooling, and TypeScript ESLint.
- Moves runtime dependencies from the root to consuming apps.
- Adds missing jsdom declarations and removes redundant PostCSS.
| File | Description |
|---|---|
package.json |
Removes root runtime dependencies. |
pnpm-lock.yaml |
Records dependency and workspace changes. |
apps/doop/package.json |
Updates tooling and adds Zod. |
apps/greenhouse/package.json |
Updates React Query, Immer, and React tooling. |
apps/heureka/package.json |
Updates dependencies, adds Zod, and removes PostCSS. |
apps/supernova/package.json |
Updates dependencies and adds Zod. |
apps/template/package.json |
Updates React and jsdom tooling. |
packages/communicator/package.json |
Updates jsdom and declaration tooling. |
packages/config/package.json |
Updates TypeScript ESLint. |
packages/greenhouse-auth-provider/package.json |
Adds jsdom and updates declaration tooling. |
packages/k8s-client/package.json |
Adds jsdom and updates declaration tooling. |
packages/messages-provider/package.json |
Adds jsdom and updates declaration tooling. |
packages/oauth/package.json |
Adds jsdom and updates declaration tooling. |
packages/template/package.json |
Updates jsdom and declaration tooling. |
packages/ui-components/package.json |
Updates Vite, React, and jsdom tooling. |
packages/url-state-provider/package.json |
Updates jsdom and declaration tooling. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>

Summary
This PR upgrades multiple dependencies to their latest patch versions and fixes monorepo architecture issues by ensuring all dependencies are explicitly declared where they are used, rather than relying on hoisting or incorrect root dependencies.
Changes Made
Dependency Upgrades (Patch Versions)
Architecture Fixes
Removed unnecessary dependencies from root package.json:
@tanstack/react-query@5.103.1(production deps should not be in monorepo root)zod@4.6.5(production deps should not be in monorepo root)Fixed missing explicit dependencies (were relying on hoisting):
zod@4.6.5to: apps/doop, apps/heureka, apps/supernovajsdom@30.1.2to: packages/greenhouse-auth-provider, packages/k8s-client, packages/messages-provider, packages/oauthRemoved redundant dependency:
postcss@8.5.28from apps/heureka (Vite provides it internally)Related Issues
Screenshots (if applicable)
N/A - No visual changes
Testing Instructions
pnpm installpnpm build- Verify all packages build successfullypnpm test- Verify all tests pass (1,734 tests)pnpm lint- Verify linting passespnpm typecheck- Verify TypeScript compilationpnpm check-format- Verify code formattingChecklist
PR Manifesto
Review the PR Manifesto for best practises.