Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5120 +/- ##
=======================================
Coverage 97.70% 97.71%
=======================================
Files 990 991 +1
Lines 31818 31858 +40
Branches 11753 11770 +17
=======================================
+ Hits 31089 31130 +41
- Misses 683 721 +38
+ Partials 46 7 -39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vvaliyev
marked this pull request as ready for review
October 14, 2026 09:11
vvaliyev
requested review from
gethinwebster and
vikaskale2722
and removed request for
a team
October 14, 2026 09:11
vvaliyev
requested review from
gethinwebster
and removed request for
gethinwebster
October 14, 2026 09:39
vvaliyev
enabled auto-merge
October 14, 2026 10:57
gethinwebster
approved these changes
Oct 14, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2026
gethinwebster
requested changes
Oct 14, 2026
gethinwebster
left a comment
Member
There was a problem hiding this comment.
Actually, I've looked into this approach in more detail and I think it's very risk-prone, I think it needs more discussion
pan-kot
marked this pull request as draft
October 19, 2026 08:51
pan-kot
force-pushed
the
chore-badge-style-api-alt
branch
from
October 20, 2026 10:03
38478ff to
ecae700
Compare
pan-kot
force-pushed
the
chore-badge-style-api-alt
branch
from
October 20, 2026 10:05
ecae700 to
eb8398b
Compare
Member
Author
|
Closed in favour of #5165 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Course correction for Style API v2 (design doc RsrNx38C0132): Badge no longer exposes style tokens. Its root slot now documents eligible CSS properties (color, background, border, border-radius, padding, font-family, font-size, font-weight) that consumers set directly, with the styling.override mixin raising specificity. The component CSS goes back to plain design-token values; only the docs annotation changes.
Depends on: cloudscape-design/component-toolkit#264
How has this been tested?
The PR deliberately does not include tests for the generated mixins: we will cover them later with a snapshot test - similar to style docs. However, during development these tests cause git conflicts when multiple components are added in parallel.
The generated mixins can be inspected in
./lib/components/stylingReview checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.