Skip to content

chore: Fixes internal build error caused by new styling mixin imports in test pages - #5170

Merged
pan-kot merged 1 commit into
mainfrom
fix-style-mixins-use-in-test-pages
Oct 22, 2026
Merged

pan-kot merged 1 commit into
mainfrom
fix-style-mixins-use-in-test-pages

Conversation

@pan-kot

@pan-kot pan-kot commented Oct 21, 2026

Copy link
Copy Markdown
Member

Description

#5165 introduced new Sass utils imports in test pages. The test pages are built separately in the internal pipeline - causing issues due to local ../../lib/ exports no longer resolvable. This is addressed by aliasing these imports - same as it works today for design tokens.

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov

codecov Bot commented Oct 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.73%. Comparing base (b655074) to head (2cf34a2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5170   +/-   ##
=======================================
  Coverage   97.73%   97.73%           
=======================================
  Files         996      996           
  Lines       32178    32178           
  Branches    11872    11872           
=======================================
  Hits        31449    31449           
  Misses        723      723           
  Partials        6        6           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pan-kot
pan-kot marked this pull request as ready for review October 21, 2026 16:04
@pan-kot
pan-kot requested a review from a team as a code owner October 21, 2026 16:04
@pan-kot
pan-kot requested review from taheramr and removed request for a team October 21, 2026 16:04
@pan-kot
pan-kot enabled auto-merge October 21, 2026 16:36
@pan-kot
pan-kot added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit 010510f Oct 22, 2026
70 checks passed
@pan-kot
pan-kot deleted the fix-style-mixins-use-in-test-pages branch October 22, 2026 06:45

This branch was successfully deployed

3 active deployments
dev-pages-react18 — 2cf34a2c Deployed Oct 21, 2026 by pan-kot via deploy (React 18) / deploy #2904
dev-pages-react16 — 2cf34a2c Deployed Oct 21, 2026 by pan-kot via deploy (React 16) / deploy #2904
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants