Repository navigation
[Spec 1658] windows-native-non-wsl-support - #1859
Open
amrmelsayed wants to merge 235 commits into
Open
amrmelsayed wants to merge 235 commits into
amrmelsayed wants to merge 235 commits into
Conversation
…rkflow, platform seam, site audit
…l install; quote the dispatch filter
…source builds from npm output; probe the published package
… installs with a user's npm environment
… uses npm's default cmd.exe script shell; review Phase 11 section
…paint to reach the mirror (ConPTY splits the alt-screen switch from the paint); launchers postSpawn assertion carries the spawn output
… an entry sentinel; a miss reports runner log, sentinel, where hook files landed, worktree state and a 5 s late-write recheck
…ee id (base64url, may contain - and _); the intermittent postSpawn miss was the test reading worktree-MF for worktree-MF-L
…Windows unit failures and their causes
…matches the install gate; PR-time dispatch names install_guard
Collaborator
Author
Architect integration review (main), round 1, head 1b78fc0Risk tier: High (350 files, +23327/-1165; shellper transport, Tower lifecycle, render gate, install path). Three-way read: Claude REQUEST_CHANGES, Codex REQUEST_CHANGES, Gemini skipped (agy signed out on the review host). Both verdicts block on the same items the PR body itself declares open, and neither found a product defect in the merged code. Verified sound (not re-raised)
Blocking before the pr gate (already the agreed conditions)
Must-fix in this lane before the gate request
Follow-ups to file separately (not blocking)
|
…l PID-reuse recheck, System32 paths for system programs, POSIX shellper info read gated, sdk charter, #1858 known gap, jira jq failure visible
…d as a Windows release blocker, with site inventory
…ittents after the PR opened
…t runs the source under tsx (no dist needed); temp-dir test tolerates a host temp dir under /tmp
…dows runs after the PR opened
…smith/codev-ide-win32-x64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Native (non-WSL) Windows support at parity with macOS and Linux, built over 12 phases (1-11 plus 3b) in one PR. WSL 2 stays documented as a supported alternative.
Closes #1658
Changes
killSessionTreesession teardown, and a per-session Job Object for re-parented descendants. Orphan and husk sweeps work on Windows.tower stopover HTTP (POST /api/shutdown: keyed, local, not tunnel-borne). A Tower started inside a session launches through CIM so it survives that session.codev-sdk/node/executable) and an MSYS path translator. Forge, spawn, postSpawn,afx devand porch checks all route through them. PowerShell for human shells.codeventrypoint, which was a silent no-op on Windows, and a drive-root hang. Apreinstallguard refuses a Node version that has no prebuilds.doctorgains Windows prerequisite checks.windows.yml(dispatch only, never required): probes, targeted tests, and theunit/cli-e2e/post-release-e2esuites on Node 22 and 24.Testing
.gitattributesrule for the gate fixtures.Known gaps (recorded in the review)
Open before the pr gate
fixtures/gate/conpty/. Codex fixtures are blocked on Render gate holds all mail to Codex agents: region-end pattern misses the 'GPT-6.1-Sol default' status line #1858.Spec
codev/specs/1658-windows-native-non-wsl-support.md
Review
codev/reviews/1658-windows-native-non-wsl-support.md