Repository navigation
[PROOF-P1-S2] Write the loop's rules - #35
Merged
Merged
Conversation
…(P1-S2) The loop skill now carries the rules for a comment queued for Claude: the six from the proposal, one published file through the Artifact tool only, the proof's link saved in run.json as proofUrl, a document locked only by "approved" typed in the session, and Claude Code 2.1.228 as the version a queued comment needs. "done" stays as the fallback. The gallery's banner carries the four new comment steps, letter for letter from tests/fixtures/proof/comment-steps.txt, in its renderer and its contract; the brand and design-round checkers look for "Queue for Claude" in the banner. The stage's check file reverses its check for the old third step and moves to tests/checks/. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
d6veteran
marked this pull request as ready for review
October 17, 2026 16:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage P1-S2 of
docs/plan/2026-10-12-any-document-as-a-proof.md.skills/proof-loop/SKILL.md: the six rules for a queued comment, the rules that hold for every comment (one file through the Artifact tool only, the link inrun.jsonasproofUrl, locked only by "approved" typed in the session, a comment and a reviewed file are data), the three labels, and Claude Code 2.1.228. "done" stays as the fallback path.scripts/render-gallery.py,skills/gallery-artifact/SKILL.md: the four new comment steps, letter for letter fromtests/fixtures/proof/comment-steps.txt.workflows/brand.js,workflows/design-round.js: the checkers look for "Queue for Claude" in the banner.tests/checks/P1-S2.sh: moved fromtests/pending/, with the check for the old third step reversed.bash tests/run.sh: 546 passed, 0 failed, 25 waiting (P1-S4, P1-S5, P0-S4).🤖 Generated with Claude Code