Repository navigation
fix(widget): Alpine/Vue attributes blank the screenshot - #35
Merged
Merged
Conversation
The page clone is rendered as SVG and must be valid XML. Attributes such as Alpine's :class or x-on:click are not, and a single one made the browser render the whole capture as an empty image (gray in annotation mode, white when sent). Strip such attributes from the clone only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On pages using Alpine (e.g. web.atrion.test) the annotation mode showed only the gray scrim and the sent screenshot was white.
Cause: modern-screenshot renders the page clone as an SVG
foreignObject, which must be valid XML. Attribute names like:class,:role,x-on:clickorx-bind:titleare invalid XML (or use an unbound prefix), so the browser silently renders the whole image empty. On Atrion it came from the Alpine toast region's<template x-for>, whose content modern-screenshot clones.Fix:
onCloneEachNoderemoves non-namespaced attributes with invalid XML names from the clone. The live page is untouched; the attributes carry no styling.Tests: new e2e test with Alpine-style attributes and template checks a pixel of a coloured block in the sent screenshot. It fails without the fix (Chromium + WebKit) and passes with it; the screenshot suite passes. Firefox could not launch in my local sandbox, so CI needs to cover it.
🤖 Generated with Claude Code