Repository navigation
fix(codefresh-run): terminate the child build only on timeout - #740
Merged
Merged
Conversation
With TERMINATE_ON_TIMEOUT=true the step terminated the child build on any `codefresh wait` failure, including temporary API errors (e.g. 520), so healthy child builds were killed. Now the build is terminated only when the timeout is reached. The timeout is detected by exit code 124 (CLI >= 1.3.0) or by the "Operation has timed out" message, so the default CLI image keeps working. Fixes CF-2404
masontikhonov
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With TERMINATE_ON_TIMEOUT=true the step terminated the child build on any
codefresh waitfailure, including temporary API errors (e.g. 520), so healthy child builds were killed.Now the build is terminated only when the timeout is reached. The timeout is detected by exit code 124 (CLI >= 1.3.0) or by the "Operation has timed out" message, so the default CLI image keeps working.
Fixes CF-2404
What
Why
Notes