Conversation
|
Thank you for the PR! This looks like something we ought to contribute to VS Code itself rather than maintaining as a patch here. Could we send this up to https://github.com/microsoft/vscode? |
Thanks for the feedback! I completely agree — this is better suited to VS Code itself rather than being maintained as a patch here. I'm happy to send it upstream to https://github.com/microsoft/vscode. I'll open a PR/issue there and link back to this discussion. Do you want me to close this PR in the meantime, or keep it open until the upstream change is merged? |
|
Awesome thank you! I think we go ahead and close for now, and we can reopen if there ends up being something code-server-specific we have to fix. |
Summary
Validation
npm run buildnpm run gulp compile-webnpm run compile-clientmarkdown.stylesis applied correctly.The targeted Playwright E2E test is currently blocked before the workbench loads by an unrelated CSS module MIME-type issue in the development build.
Fixes #7913