Repository navigation
test(e2e): screenshot tests for the widget's states, with a workflow that makes the baselines - #463
Merged
Merged
Conversation
…that makes the baselines
This was referenced Oct 29, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rest of W7 (F-05 task 33), as decided: screenshot baselines made on CI and committed by a workflow.
e2e/tests/visual.spec.tsscreenshots seven states (launcher, welcome bubble, suggestions, pre-chat form, sources, retryable error, phone) in light, dark and right-to-left. That's 21 images, compared withe2e/screenshots/at a 1% pixel tolerance, with animations off and the caret hidden.E2E_CHANNEL. Until baselines exist it skips with "run the Update screenshots workflow", so this PR can merge before them..github/workflows/update-screenshots.yml(manual,branchinput):--update-snapshots, and commitse2e/screenshots/to the branch.devorproduction, which only take PRs, it pushes ascreenshots/<run id>branch and opens a PR.gh workflow run ci.yml. That's whyci.ymlgainsworkflow_dispatch. The changeset job only runs forpull_request, so it skips on that run.branchinput goes into the shell through an env var, not${{ }}. Only people with write access can run a workflow by hand.After this merges I'll run the workflow on
devto make the first baselines. It has to be ondevto show up under Run workflow.Tested: I lifted the Linux check locally once and made all 21 images in Chrome. They look right (I opened a few), and I didn't commit them. Without the override, the spec skips all 21 locally. The rest of the e2e suite and lint are unchanged.