Repository navigation
test(e2e): wait for the reply to end before the S7 and S14 screenshots - #466
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S7 took its screenshot as soon as the sources link showed. Sources arrive just before the reply's
finish, so the shot could land on either side of it. S14 waited only for the text, with the same race. Both now wait for the Regenerate button, which appears withfinish.The Update screenshots workflow (its first run on a PR branch) made the images again from this branch and found nothing to change. So the baselines were already of the finished state, and the space under the sources in S7 is the reserved actions row, whose Regenerate button shows on hover on desktop. This only removes the race.