Repository navigation
ci: room in the widget budgets for the reply actions and the header menu - #508
Merged
Merged
Conversation
This was referenced Oct 31, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last P2 widget features don't fit in the budgets set in #469. The Stop button (#498) and offline sending (#502) have used up the headroom. Two more are in review:
So this raises the budgets:
The loader stays at 5 kB, since that's what every page downloads. The panel only loads when the chat opens. CONTRIBUTING has the new numbers.
The next way to get room back, before raising again: about 17.6 kB of the panel is ours, and some of it repeats what the loader already sent. The panel draws its own launcher, so
launcher.css(about 1.1 kB gzipped on its own), the launcher button, the welcome bubble and the theme code all ship twice. Reusing the loader's launcher would be a refactor of the hand-over insrc/loader/loader.ts:142, so it's left for its own PR.How I tested this
pnpm --filter @chatcops/widget buildthenpnpm sizeon dev: everything passes under the new limits.I measured the panel's bytes per source file from a sourcemap build. The biggest are
widget.tsat 5.0 kB gzipped, the inlined CSS inshadow.tsat 3.3 kB, andmessages.tsat 2.8 kB. Mangling more names (#453) has nothing left to give.