Repository navigation
feat: add error explained tutorial template - #286
Conversation
Signed-off-by: Anurag Yadav <anuragyadav2787@gmail.com>
|
Hi @anurag629 could you please review and let me know if any changes required |
anurag629
left a comment
There was a problem hiding this comment.
Thanks @anurag2787, this is close. Check, all 1429 tests and the build pass on top of dev, and the card looks right with the defaults, on a white background with a pale accent, with a long error message and with blank fields.
One thing: when the meaning or the fix runs to two lines, its label lines up with the last line instead of the first. With a meaning like "You called .map() on a value that is still undefined, usually because the data has not loaded yet", MEANING sits next to "has not loaded yet". The two rows use alignItems: 'baseline' (lines 99 and 142), and in the rendered card that puts the label next to the last line. alignItems: 'flex-start' with a few pixels of top margin on the label would keep it next to the first line. Could you change that?
Signed-off-by: Anurag Yadav <anuragyadav2787@gmail.com>
|
Hi @anurag629 i have updated PR could you please re review |
anurag629
left a comment
There was a problem hiding this comment.
Thanks @anurag2787, that fixes it. Check, all 1443 tests and the build pass on top of dev, and with a two-line meaning and fix the labels now sit next to the first line.
Description
Added the tutorial-error-explained template to show an error message
Closes #283
How I Tested This
Ran npm run check and npm run test
AI Assistance
ChatGPT was used to help with the implementation and tests
Type of Change
Screenshots
Checklist
devnpm run checkpassesnpm run testpassesnpm run dev