Repository navigation
chore(ci): setup-pnpm reads version from packageManager - #107
Merged
Merged
Conversation
pnpm/action-setup@v4 refuses to run when its 'version' input disagrees with
packageManager in package.json ('Multiple versions of pnpm specified:
11.1.3 in the GitHub Action config' after the pin moved to 12.21.0). Drop
the hardcoded input in publish.yaml and the passed-through one in the
composite action (keep the parse step for the cache key), so package.json
is the single source of truth.
Farenheith
requested review from
Dodt,
danielgalleni,
douglasdrdc,
fgabrielsilva and
pedrosodre
as code owners
November 19, 2026 01:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
publish.yaml pinned
version: 11.1.3forpnpm/action-setup@v4; after #106 moved the pin topnpm@12.21.0, the action refuses to run: Multiple versions of pnpm specified. Drops both hardcoded/passed-throughversioninputs (publish.yaml + composite action); the composite keeps its parse step solely for the pnpm cache key.benchmark.yamlalready uses the action bare — consistent now.chorecommit: no release triggers. YAML parses; no other pinned pnpm versions left under.github/.