Repository navigation
Add an optional query telemetry adapter - #343
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional
QueryTelemetryAdapter@qbso qb owns its query execution listeners. Applications explicitly select it; qb does not require Sentry or install a telemetry client.configure(context)accepts a telemetry object and returns{mode:"custom",shutdown:callback}. The adapter skips pretend/manual observations, supports nested queries, restores the enclosing scope, and completes success/error spans once. Only scrubbed SQL and database-system metadata are passed to telemetry; bindings, options, results and exception contents stay out.Each setup owns a unique registration. Shutdown rejects new observations and retains completion hooks until observed queries finish, then unregisters only that registration. A query that never completes can keep its completion hooks registered; shutdown does not cancel database calls.
The consumer configuration and removal of Sentry's qb-specific interceptor are in Sentry draft PR #56. Neither module adds a package dependency on the other.
Schema
createView,createAsandalterViewalso use the module-qualifiedqb.models.Query.QueryBuilderconstructor. The old webroot-relativemodels.Query.QueryBuilderpath could load the same CFC under an alternate identity; on Adobe, running schema work first then rejected valid builders at a fully qualified typed boundary. The constructor correction preserves the original nominal argument/return checks and removes dependence on a consumer's webroot/modelspath.Checks
1and assert exact1, avoiding unrelated engine differences in boolean-to-bit normalization. The original retrievable wrapper and its existing spec are unchanged.release()method-name collision with the generated page lifecycle; helpers use explicit execution names. The schema identity correction passed independent review too.d846c4a; all 35 PR checks are green.Configuration and adapter contract