Repository navigation
Split incident report other location, add tags filter and citizen report locations count - #1123
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…n report locations count - IncidentReportLocationType.OtherLocation is split into OtherPollingStation and NotRelatedToAPollingStation; both require a location description. Existing OtherLocation rows are migrated to NotRelatedToAPollingStation, and the legacy value is still accepted from clients (JSON, query params and V2 filters). - V2 report filters for submissions and incidents support "tags" (has any of / has none of) through a new array filter field. - Citizen report V2 aggregates count the distinct citizen report locations at the root, per location and per option / rating value (LocationsHistogram).
idormenco
force-pushed
the
feat/incident-location-types-and-tags-filter
branch
from
October 18, 2026 10:08
e8d4325 to
19b35cc
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Incident report location types
OtherLocationis split intoOtherPollingStationandNotRelatedToAPollingStation. Both requirelocationDescription.RenameIncidentReportOtherLocationmoves existingOtherLocationrows toNotRelatedToAPollingStation.OtherLocationvalue is still accepted (JSON bodies, query params and the V2locationTypefilter) and maps toNotRelatedToAPollingStation, so older mobile clients keep working.Tags filter in V2 reports
tagswithin(has any of) andnotIn(has none of).FilterFieldgainsIsArray; for array fields the compiler emits an array overlap (&&) check.Citizen report locations count
AddCitizenReportLocationsCountupdates the aggregate SQL functions.locationsCountat the root and per location, andlocationsHistogramon single select, multi select and rating aggregates.Test plan
Vote.Monitor.Core.UnitTests, including new array filter compiler testsVote.Monitor.Domain.UnitTests, including new location type and V2 filter field testsFeature.IncidentReports.UnitTestsVote.Monitor.Hangfire.UnitTests