Repository navigation
Fix null display logic validation and show validation errors on save - #1126
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
… save - Normalize null display logic value/optionIds returned by the API to undefined, so existing questions no longer fail validation with "Expected array, received null". - Load display logic optionIds in the translation editor so AnyOf/All conditions are not dropped when saving translations. - Show a toast listing validation errors when saving an invalid form.
idormenco
force-pushed
the
fix/form-validation-feedback
branch
from
October 19, 2026 09:17
bc5ba11 to
578acc1
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nullfor the unused display logic field (optionIdsfor Includes,valuefor AnyOf/All). The editor passed thenullthrough, but the zod schema only allowsundefined. Both fields are now normalized toundefinedwhen the form loads.optionIds. Before, saving a translation dropped the selected options of AnyOf/All conditions.Question 3 (Q3) › Display logic options: ...). This helps when the error is on a tab that isn't open.Test plan