[cpyrt] Check has_value before forwarding optional attributes - #120
Merged
aaronj0 merged 1 commit intoSep 30, 2026
Merged
Conversation
aaronj0
force-pushed
the
optional-has-value-getattr
branch
from
September 29, 2026 15:12
9bb9952 to
11fc3c4
Compare
guitargeek
approved these changes
Sep 29, 2026
guitargeek
left a comment
guitargeek
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Given the CI failures are fixed or understood.
Collaborator
Author
unrelated, just the wheels that are still trying to pull in LLVM21: #122 fixed here |
Attribute lookups on std::optional and std::expected went through operator* and dereferenced a disengaged value, which IPython's rich-display probes (_repr_html_ and friends) trigger on every empty optional. Ask has_value() first: an empty or error state raises AttributeError, an engaged value forwards as before. Co-authored-by: Juan Miguel Carceller <jmcarcell@users.noreply.github.com>
aaronj0
force-pushed
the
optional-has-value-getattr
branch
from
September 29, 2026 16:46
11fc3c4 to
06c820b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attribute lookups on std::optional and std::expected went through operator* and dereferenced a disengaged value, which trigger on empty optionals. Ask has_value() first: an empty or error state raises AttributeError, an engaged value forwards as before. Based on the patch submitted to ROOT: root-project/root#23460