Repository navigation
Conversation
The xrealloc() for opt_sync_fd uses sizeof (&opt_sync_fd[0]), which is the size of a pointer rather than of an int. This only over-allocates, so it is harmless, but it was clearly meant to be the element size. Signed-off-by: Armaan Sandhu <armaan.sandhu0504@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny follow-up to #815: the
xrealloc()foropt_sync_fdusessizeof (&opt_sync_fd[0]), which is the size of a pointer (8) rather than of anint(4). It only over-allocates, so nothing breaks, but it was clearly meant to besizeof (opt_sync_fd[0]).Built with meson on Fedora 44 without warnings, and
bwrap --sync-fd 3 --sync-fd 4 ...still works.