Skip to content

Fix: replace hardcoded credentials in tests (Snyk) #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reeshika-h wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Fix: replace hardcoded credentials in tests (Snyk) #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/test/java/com/contentstack/cms/TestClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.contentstack.cms;

import java.util.UUID;
import com.contentstack.cms.core.Util;
import com.contentstack.cms.stack.Stack;
import io.github.cdimascio.dotenv.Dotenv;
Expand All @@ -17,8 +18,8 @@ public class TestClient {
public final static String USER_ID = (env.get("userId") != null) ? env.get("userId") : "c11e668e0295477f";
public final static String OWNERSHIP = (env.get("ownershipToken") != null) ? env.get("ownershipToken")
: "ownershipTokenId";
// file deepcode ignore NonCryptoHardcodedSecret/test: <please specify a reason of ignoring this>
public final static String API_KEY = (env.get("apiKey") != null) ? env.get("apiKey") : "apiKey99999999";
public final static String API_KEY = (env.get("apiKey") != null) ? env.get("apiKey")
: "blt" + UUID.randomUUID().toString().replace("-", "").substring(0, 16);
public final static String MANAGEMENT_TOKEN = (env.get("managementToken") != null) ? env.get("managementToken")
: "managementToken99999999";

Expand Down
7 changes: 4 additions & 3 deletions src/test/java/com/contentstack/cms/models/LoginDetailTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.contentstack.cms.models;

import java.util.UUID;
import com.contentstack.cms.core.AuthInterceptor;
import okhttp3.Interceptor;
import okhttp3.internal.http.RealInterceptorChain;
Expand Down Expand Up @@ -102,9 +103,9 @@ void getterSetterUserModelLastName() {
@Test
void getterSetterUserModelUsername() {
UserModel userModel = new UserModel();
// deepcode ignore NoHardcodedCredentials/test: <please specify a reason of ignoring this>
userModel.setUsername("***REMOVED***");
Assertions.assertEquals("***REMOVED***",
String username = UUID.randomUUID().toString();
userModel.setUsername(username);
Assertions.assertEquals(username,
userModel.getUsername());
}

Expand Down
Loading