Conversation
CI fails a PR that edits registry.yaml but doesn't regenerate the derived files (git diff --exit-code), but neither doc told contributors to run the generator before opening a PR. Mirrors the existing "Validating a Descriptor" note in plugin-descriptor-schema.md. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughContributor instructions now include the command to generate registry files. The README.md instructions specify committing the generated README.md and registry.json and note that CI checks for drift from registry.yaml. ChangesRegistry contributor guidance
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested labels: Merge Risk: ⚪ Minimal · up to The updated guidance accurately tells contributors how to regenerate and include the registry outputs. No merge-blocking issue is identified. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 2 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 16 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (16 passed)
Full details: Ai Contribution DisclosureExplanation
Resolution Add lowercase Full details: Renovate: Config Present And ValidExplanation FAIL — the PR modifies the repository root (
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
git diff --exit-code -- README.md registry.jsonbecause it editedregistry.yamlwithout regenerating the derived files.README.mdnordocs/registry-schema.mdtold contributors to run the generator before opening a PR, unlikedocs/plugin-descriptor-schema.md's existing "Validating a Descriptor" note forplugin.yaml.uv run scripts/generate_registry.pyinstruction to both.Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit