Conversation
In section [dcl.init.general]/21, the phrase 'Destroying a scalar type has no effect' was missing the word 'object', making it grammatically incomplete. The sentence should read 'Destroying a scalar type object has no effect other than ending the lifetime of the object'. Issue: cplusplus#9346
| \end{note} | ||
| Destroying an object of class type invokes the destructor of the class. | ||
| Destroying a scalar type has no effect other than | ||
| Destroying a scalar type object has no effect other than |
There was a problem hiding this comment.
Please rephrase in the same way as the preceding sentence: "Destroying an object of scalar type..."
jensmaurer
added
the
changes requested
Rephrase from 'a scalar type object' to 'an object of scalar type' to match the structure of the preceding sentence: 'Destroying an object of class type invokes the destructor...'
| Destroying an object of class type invokes the destructor of the class. | ||
| Destroying a scalar type has no effect other than | ||
| Destroying an object of scalar type has no effect other than | ||
| ending the lifetime of the object\iref{basic.life}. |
There was a problem hiding this comment.
Hi @jensmaurer, thanks for the review! My PR (commit 2dd3f2e) already changes the wording to match the preceding sentence: 'Destroying an object of scalar type has no effect other than ending the lifetime of the object.'
Please let me know if you'd like a different phrasing or if I should make any other adjustments. Happy to address any further feedback.
jensmaurer
removed
the
changes requested
|
Hi @jensmaurer, I've now pushed a follow-up commit (9f01037) that rephrases to 'an object of scalar type' to match the preceding sentence pattern exactly. The PR now contains both fixes: the missing 'object' word and the corrected phrasing. Let me know if there's anything else needed! |
3 participants
Fix: add missing 'object' in [dcl.init.general]/21
In section [dcl.init.general]/21 (link), the phrase 'Destroying a scalar type has no effect' was missing the word 'object', making it grammatically incomplete.
Before:
After:
Fixes #9346