Skip to content

Fix #12421 eraseIteratorOutOfBoundsCond: value is missing condition #8883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrchr-github wants to merge 3 commits into
base: main
Choose a base branch
from
+17 −3
Open

Fix #12421 eraseIteratorOutOfBoundsCond: value is missing condition #8883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
212e735
Update checkstl.cpp
chrchr-github Sep 23, 2026
662c6ce
Update teststl.cpp
chrchr-github Sep 23, 2026
3fc280c
Update teststl.cpp
chrchr-github Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/checkstl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3338,8 +3338,8 @@ void CheckStlImpl::eraseIteratorOutOfBoundsError(const Token *ftok, const Token*
}

const Severity severity = isConditional ? Severity::warning : Severity::error;
const std::string id = isConditional ? "eraseIteratorOutOfBoundsCond" : "eraseIteratorOutOfBounds";
reportError(ftok, severity,
const char* id = isConditional ? "eraseIteratorOutOfBoundsCond" : "eraseIteratorOutOfBounds";
reportError(getErrorPath(ftok, val, msg), severity,
id,
msg, CWE628, Certainty::normal);
}
Expand Down
16 changes: 15 additions & 1 deletion test/teststl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1140,6 +1140,20 @@ class TestStl : public TestFixture {
"[test.cpp:3:11]: note: Assuming that condition 'i>5' is not redundant\n"
"[test.cpp:5:13]: note: Access out of bounds\n",
errout_str());

check("void f(std::vector<int>& v) {\n"
" std::vector<int>::iterator it;\n"
" for (it = v.begin(); it != v.end(); ++it) {\n"
" if (*it == 0)\n"
" break;\n"
" }\n"
" v.erase(it);\n"
"}\n", s);
ASSERT_EQUALS("[test.cpp:4:13]: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm]\n"
"[test.cpp:7:7]: warning: Either the condition is redundant or function 'erase()' is called on the iterator 'it' which is out of bounds. [eraseIteratorOutOfBoundsCond]\n"
"[test.cpp:3:29]: note: Assuming that condition 'it!=v.end()' is not redundant\n"
"[test.cpp:7:7]: note: Either the condition is redundant or function 'erase()' is called on the iterator 'it' which is out of bounds.\n",
errout_str());
}

void iterator1() {
Expand Down Expand Up @@ -2441,7 +2455,7 @@ class TestStl : public TestFixture {
" if (it == v.end()) {}\n"
" v.erase(it);\n"
"}\n");
ASSERT_EQUALS("[test.cpp:3:7]: (warning) Either the condition 'it==v.end()' is redundant or function 'erase()' is called on the iterator 'it' which is out of bounds. [eraseIteratorOutOfBoundsCond]\n",
ASSERT_EQUALS("[test.cpp:2:12] -> [test.cpp:3:7]: (warning) Either the condition 'it==v.end()' is redundant or function 'erase()' is called on the iterator 'it' which is out of bounds. [eraseIteratorOutOfBoundsCond]\n",
errout_str());

check("void f() {\n"
Expand Down
Loading