Repository navigation
fix: keep H2 failed response cleanup out of dial budgets - #75
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
An H2 CONNECT that already received an authenticated error (or loses the caller during handoff) can synchronously block in response Body.Close. With unread DATA, Go's HTTP/2 transport needs the shared write lock to return flow-control credit before checking cancellation. A stalled SETTINGS ACK can therefore extend a failed caller's wait to the physical write timeout.
Fix
Validation
Tested head
f38bce5b3e0d794ed3c72e75359f611c94704564, tree36bae0bb1eaf8713d39138319533ecdace0cf05a, Go 1.27.2:make checkand all-packagego test -race -shuffle=on -count=1 -timeout=5m ./...passed.0d371d8aeadb55d9c5b4d7f199857b179a5e2cbf6be3a7014bbb63bd62cf6222.The new fixture uses real TLS verification, H2 frames and response proofs over a bounded net.Pipe peer. Its subsequent healthy stream is a same-connection continuation control, not a new simultaneous-sibling or invalid-MAC test. Existing sibling and authentication tests remain in the full suite. No fingerprint profile, dependency, on-wire authentication format, release tag or comparative traffic claim is changed.