Repository navigation
fix(flow): bind router feedback to its producing invocation - #9591
Draft
Wang guanyu (wang1299) wants to merge 1 commit into
Draft
Wang guanyu (wang1299) wants to merge 1 commit into
Wang guanyu (wang1299) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Fixes #9586
Summary
After human feedback is recorded, an ordinary router can pass that old
HumanFeedbackResultto its outcome listeners instead of its own return value. This also affects later kickoffs and pending-feedback recovery.Carry the optional feedback object from the producing method invocation through the private execution return value. Capture it before persistence/downstream awaits, so another concurrent review cannot replace it. Ordinary routers keep their own payload; real HITL outcomes retain their feedback object and public feedback history stays intact.
This is an alternative to #9590. A method-name check against shared history is insufficient when another review finishes during persistence; comparing the upstream trigger name also loses real listener-based HITL feedback. This change includes behavioral regressions for both cases.
Verification
crewai_tools.from_pending, then resume completes withINVOICE_READY.uv build --package crewaiwheel/sdist on Python 3.12.16: passed.crewai_filestypes; unchanged main reproduces the same 6 diagnostics on the same lines. Providing the workspace'screwai-filessources viaMYPYPATHremoves runtime-file diagnostics but reports 13 dependency/stub-related diagnostics in 6 optional-package files. No workspace-wide mypy pass is claimed.45fe858408f4b47e377b5cb4603fe99a5de4a45e: no blocking substantive findings; this is not maintainer approval.The same 16 tests against #9590 at
7ed47064e1b224e73c0880784b9dc878c5980645produce 5 failed, 11 passed (listener HITL, chained reviews and concurrent start reviews). This compares source behavior in the same locked core+dev environment, not that PR's full CI.Additional context
Only private
_execute_methodand_execute_single_listenerreturn tuples change from two to three elements; external overrides of these private methods may need adaptation. Public APIs and persisted/checkpoint schemas are unchanged. Sibling-route scheduling and broader checkpoint restoration are outside scope.AI-assisted contribution. The issue's label request returned HTTP 403; please apply the required
llm-generatedlabel if the contributor integration cannot. Maintainer assignment/scope acceptance remains pending. No live model calls, production load or browser validation.