Repository navigation
Conversation
Feat/dns nameservers
Use the new `index` field of the CMDB port layout instead of guessing it from the port short name. No index is emitted when the layout has none.
kpetremann
approved these changes
Oct 23, 2026
| ethernet.Index = &index | ||
| } else { | ||
| log.Debug().Msgf("no port index derivable from %q for interface %s of %s", port.VendorShortName, deviceInterface.Name, hostname) | ||
| log.Debug().Msgf("no port index in the port layout of interface %s of %s", deviceInterface.Name, hostname) |
Member
There was a problem hiding this comment.
it should be an error no?
FAR: maybe same for Lanes above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Take the front-panel port index from the new
indexfield of the CMDB port layout instead of guessing it from the port short name.Guessing broke on platforms whose short names don't match the NOS index (e.g. numbered from zero).
When the layout has no index, none is emitted. Breakout ports share the index of their parent port.
Before the commit:
Index derived from the short name:
etp1→0etp3a→2etp0→ no indexAfter the commit:
Index taken as is from the CMDB port layout.