Skip to content

fix: expose max-send-message-size #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fernandezcuesta wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −4
Open

fix: expose max-send-message-size #237

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5c7186
fix: expose max-send-message-size
fernandezcuesta Sep 21, 2026
9a0c9a6
fix: lint
fernandezcuesta Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions crossplane/function/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,21 @@ def cli(cache_size, **kwargs):
def standard_options(func: F) -> F:
"""Apply the standard Composition Function CLI options to a Click command."""

@click.option(
"--max-send-message-size",
type=int,
default=None,
envvar="MAX_SEND_MESSAGE_SIZE",
help="Maximum size of sent gRPC messages in MB. "
"Defaults to --max-recv-message-size.",
)
@click.option(
"--max-recv-message-size",
"--max-grpc-message-size",
type=int,
default=DEFAULT_MAX_RECV_MESSAGE_SIZE,
show_default=True,
envvar="MAX_RECV_MESSAGE_SIZE",
envvar=["MAX_RECV_MESSAGE_SIZE", "MAX_GRPC_MESSAGE_SIZE"],
help="Maximum size of received gRPC messages in MB.",
)
@click.option(
Expand Down Expand Up @@ -107,15 +116,18 @@ def run( # noqa: PLR0913
tls_certs_dir: str | None,
insecure: bool,
max_recv_message_size: int,
max_send_message_size: int | None,
) -> None:
"""Start a composition function gRPC server with standard options."""
level = logging.Level.DEBUG if debug else logging.Level.INFO
logging.configure(level=level)

size_bytes = max_recv_message_size * 1024 * 1024
if max_send_message_size is None:
max_send_message_size = max_recv_message_size

options = [
("grpc.max_receive_message_length", size_bytes),
("grpc.max_send_message_length", size_bytes),
("grpc.max_receive_message_length", max_recv_message_size * 1024 * 1024),
("grpc.max_send_message_length", max_send_message_size * 1024 * 1024),
]

runtime.serve(
Expand Down