Repository navigation
Conversation
Space-track encodes catalog IDs >= 100000 as a 5-character Alpha-5 field (A1286 = 101286). atoi() and g_ascii_strtod() stopped at the leading letter, so those satellites were stored as NORAD ID 0 and could not be selected. Decode the field with the standard Alpha-5 mapping and leave all-digit catalog numbers unchanged. Fixes csete#444
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since catalog numbers reached 100000, space-track encodes the 5-character TLE field with a leading letter (A1286 = 101286). atoi() and g_ascii_strtod() stopped at that letter, so imported satellites were stored as NORAD ID 0 and could not be selected.
This adds Convert_Sat_Catnr() with the standard Alpha-5 mapping (A–H, J–N, P–Z; I and O skipped) and uses it in Convert_Satellite_Data() and the TLE update parser. All-digit catalog numbers are unchanged. Stored TLE lines keep their original catalog field; .sat filenames and the UI still print the integer ID.
makeandmake checkpass. test-001 checks an all-digit control (25544) and the issue's A1286 TLE through Get_Next_Tle_Set (catnr == 101286).Fixes #444