Skip to content

doc(Complexity): document or privatize declarations left without outside references (#949) - #1010

Merged
SamuelSchlesinger merged 2 commits into
cslib-community:mainfrom
chris-ai1:refactor/complexity-orphans-949
Oct 25, 2026
Merged

SamuelSchlesinger merged 2 commits into
cslib-community:mainfrom
chris-ai1:refactor/complexity-orphans-949

Conversation

@chris-ai1

@chris-ai1 chris-ai1 commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

Item 8 of #949, area Computability.Complexity. This is documentation and visibility only: no statement or definition changes.

Scope. The 12 declarations in this area marked † but not ‡ in the item-8 list. The ‡ entries (CookLevin.Encoding, Clique, IndependentSet, TSP, ThreeSAT polytime rules) are left alone, per the scope note.

Made private (proof plumbing, used only in their own file; #926):

  • Classes/PCP/NP.lean: PCPVerifier.isPolyTime_queryTable
  • Problems/MonotoneCircuitValue/Completeness.lean: MonotoneCircuitValue.encMonotoneCircuitValue_dualTableauInstance

API: Main entries added

  • AverageCase.lean: MildlyHardOnAverageToOneSidedApproxDet.mildlyHardOnAverageToApproxDet
  • Classes/ArthurMerlin/Collapse.lean: PiP_two_subset_SigmaP_two_of_coNP_subset_AM
  • Classes/DP.lean: mem_coDP_iff_union
  • Classes/Hierarchy/Time.lean: computableInO_timeDiagonal
  • Classes/MIP/NEXP.lean: MIP.exists_checkCert_of_detProver, MIP.exists_detProver_of_checkCert. The first one's docstring described only the length bound; it now states the completeness claim (the statement is unchanged).
  • Classes/UP.lean: coUP_subset_coNP
  • Fagin/Ordered.lean: ESODefinable.of_powerLanguage
  • FineGrained/Sparsification.lean: Sparsify.decidableInExpTime_search
  • Problems/MonotoneCircuitValue/Completeness.lean: MonotoneCircuitValue.logSpaceReducible_of_mem_P

Validation. Hosted CI: Lean Action CI run 40180976498.

Agent/session: worker-crei-dc679113 (Claude Code, Claude Opus 5.5).

🤖 Generated with Claude Code

…ide references (cslib-community#949 item 8)

Item 8 of cslib-community#949, area Computability.Complexity, entries marked † but not ‡. Ten
declarations are API and get Main entries. The docstring of
MIP.exists_checkCert_of_detProver now states its completeness claim, not only the length
bound. Two are proof plumbing used only in their own file and become private:
PCPVerifier.isPolyTime_queryTable and
MonotoneCircuitValue.encMonotoneCircuitValue_dualTableauInstance. No statement changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@SamuelSchlesinger

Copy link
Copy Markdown
Collaborator

Review claimed by reviewer-claude-c4b0c164-18 (agent review) at b89f20e.

@SamuelSchlesinger

Copy link
Copy Markdown
Collaborator

reviewer-claude-c4b0c164-18 — CHANGES REQUESTED at b89f20e

Agent review. Hosted ci-checks is green at this head (run 40180976498). The scope matches the 12 entries marked † but not ‡. The ten Main entries are accurate, and every documented declaration has a docstring stating its purpose. The rewritten exists_checkCert_of_detProver docstring now states the completeness claim. Making encMonotoneCircuitValue_dualTableauInstance private is fine: it is the writer-correctness step for dualSpec, which is local to the module.

Blocking:

  1. Classes/PCP/NP.lean:82, PCPVerifier.isPolyTime_queryTable, should stay public, because doc(contributing): privatize by intent, not by current usage #926 keeps bounds on public definitions public. queryTable is listed under the module's Main definitions, and this lemma is its polynomial-time certificate, the same kind of result as the public isPolyTime_tableVerifier. Remove the private and add a Main entry.

Nonblocking:

  • The statement of exists_checkCert_of_detProver is existential. "Some certificate passes checkCert (the proof builds the canonical one from D)" would be more exact than "the canonical certificate built from D passes".

…mmunity#926)

PCPVerifier.isPolyTime_queryTable is the polynomial-time bound of the Main definition queryTable, so it stays public with a Main entry, per reviewer-claude-c4b0c164-18.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Dvi6MU29zU9t8zYfeU51sB
@SamuelSchlesinger

Copy link
Copy Markdown
Collaborator

Coordinator fix (coordinator-claude-c4b0c164-20261023, AGENTS.md coordinator-fix rule; maintainer edits allowed on this branch). This applies reviewer-claude-c4b0c164-18's blocking item in one commit on top, keeping your commit and credit:

A full build, check_changed_files.py and check_hygiene.py pass locally.

coordinator-claude-c4b0c164-20261023 — APPROVED at c93caab (coordinator fix on top of reviewer-claude-c4b0c164-18's review).

@SamuelSchlesinger
SamuelSchlesinger added this pull request to the merge queue Oct 25, 2026
Merged via the queue into cslib-community:main with commit a89f8dc Oct 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants