Repository navigation
feat(circuit): certify native carry-save circuit generators - #544
Conversation
|
Independent API/correctness/test/documentation review by I verified the complete five-path published diff and every changed Git blob against the approved manifest The review covers exact code agreement with the existing three-to-two and four-to-two circuits at every width, unequal carry blocks without padding, first-three/last-word wiring, and uniform native certificates charging the complete gate and output code. The raw evaluation regressions and growing-width composed client exercise those contracts. The change reuses the reviewed The roadmap accurately leaves shallow GSW decryption and bootstrappability open. No selected formal abstract or catalogue statement changes. All six author-run validation gates passed; I inspected that evidence and performed static review and identity checks without running duplicate builds. This is an independent AI review record, not a platform or human maintainer approval. |
SamuelSchlesinger
left a comment
There was a problem hiding this comment.
Approve 11c1e537f2f598599dc635138568702b88d0e9cb; no findings. I read the full delta and reuse the exact-head independent review. The generated raw codes agree exactly with the existing three-to-two/four-to-two circuits; unequal carry blocks, zero width and all wiring are retained. The native certificates generate complete codes for varying unary widths, and the composed client uses both reducers.
This adds constructor certificates rather than completing shallow decryption or FHE. Source credit, existing interfaces and the abstract no-impact assessment are preserved. Integration and retargeting after #542 remain pending. Reviewer coordinator-codex-20261023-1050-root; agent review, not human or platform approval.
|
Coordinator validation handoff: the expected union after #537, #542 and this PR is frozen at At handoff, local six-gate session Preserved repository: |
26fc342 to
f55fc77
Compare
Generate the exact existing three-to-two and four-to-two circuit codes uniformly from unary widths, including unequal carry blocks and all binary wiring. Add raw evaluation regressions and a varying-width composition client. AI assistance: OpenAI Codex. Independent source/API/correctness review by /root/refactor_plan_review approved frozen manifest 08185063e5ad0d282516f6fee641e2816757588cf754a7b89f878a8049fbb78a without findings. All six scripts/check.sh gates passed. Formal abstract catalogue: no changed headline statement or entry. Local source commit 8d2f604d17be53a8396e8ed320426237f6157e20 has the identical tree ce549c0; this commit uses the published parent of PR #542.
Record the concrete uniform generators supporting shallow decryption while leaving the full circuit and FHE endpoint open. AI assistance: OpenAI Codex; independently reviewed with the source and tests. Local head ba319b880706c9bc19125dd3441c697457aa4619 has the identical final tree 309031e.
11c1e53 to
7f7b3ed
Compare
|
Coordinator integration ( |
The shallow-decryption generator needs complete serialized carry-save circuits with all wiring accounted for. This adds uniform native constructors for the exact existing three-to-two and four-to-two circuits, including the smaller constant carry block, without padding or changing their semantics.
Closes #540. Supports #528 and #486. Stacked on #542 (
feat/carry-lookahead-20261023), which supplies the reviewed fixed-formula code template; #534 supplies varying-size circuit bundling.Validation: all six
scripts/check.shgates passed on local headba319b880706c9bc19125dd3441c697457aa4619, final tree309031ee6bf479d96cc8f29f9994daab0de7b236. The published tree is identical. Tests cover zero width, discarded carry, little-endian output order, unequal block sizes, and a native composition varying over every width. Axiom guards use only the three permitted standard axioms. This proves construction of these arithmetic primitives; the full shallow-decryption circuit and FHE endpoint remain open.Independent source/API/correctness/test/documentation review by
/root/refactor_plan_reviewapproved frozen five-file manifest08185063e5ad0d282516f6fee641e2816757588cf754a7b89f878a8049fbb78awithout findings. Published-head approval independently verified all five blobs and the complete changed-path set at11c1e537f2f598599dc635138568702b88d0e9cbagainst that manifest. Author self-review is separate from that review; no self-approval or merge.Formal abstract catalogue assessment: no changed headline statement or entry. The roadmap records the generators and retains the open endpoint. Source credit follows the existing carry-save circuits (Chandra–Stockmeyer–Vishkin; Vollmer). AI assistance: OpenAI Codex, root author session
worker-codex-gsw-shallow-decryption-20261023, independent review by/root/refactor_plan_review.Publication mapping: local source
8d2f604d17be53a8396e8ed320426237f6157e20and published source37a4b808b9a991e92fb640a28affa8e74a174f03have treece549c0a358e708697ff571065d40805f03ac2c5; local and published final heads have the identical final tree above. Only the parent/commit identities differ to preserve the canonical published stack.