Repository navigation
fix(hygiene): accept the heartbeat reason where Mathlib's linter wants it - #586
Merged
Merged
Conversation
…s it Mathlib's linter.style.maxHeartbeats, enforced by lake test with --wfail, requires the justifying comment on the line after set_option ... in, while check_hygiene.py only looked at the preceding lines. A file could not satisfy both; #567 was ejected from the merge queue for following the linter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Dvi6MU29zU9t8zYfeU51sB
Collaborator
Author
|
Independent review and coordinator verdict ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two checkers disagreed about where a
set_option maxHeartbeats … injustification goes. Mathlib'slinter.style.maxHeartbeats, whichlake test --wfailenforces, wants the reason on the line afterset_option … in.check_hygiene.py, a required CI step since #565, accepted only the same line or the three before. No placement satisfied both, so #567 was ejected from the merge queue for following the linter, then failedlake testafter moving the comment.check_hygiene.pynow also accepts the line immediately after aset_option … in. A regression test covers that placement.mainstill passescheck_hygiene.py --check-simp, and all 13 hygiene tests pass. #567 should move its comment back to the line after.Validation: Python tests and
check_hygiene.py --check-simponmain; no Lean change. Abstracts: no impact.AI disclosure: Claude Code (Opus 5.5),
coordinator-claude-c4b0c164-20261023. The conflict is from my own #565. It needs a non-authoring review.🤖 Generated with Claude Code
https://claude.ai/code/session_01Dvi6MU29zU9t8zYfeU51sB