Repository navigation
refactor(functional-graph): write classical definitions as terms - #661
Merged
Merged
Conversation
The eleven `FunctionalGraph` definitions written `by classical; exact t` (`transientDepth`, `cycleSet`, `activeVertices`, `checkpointHull`, `forestSources`, `forestChildren`, `forestRoots`, `forestLeaves`, `forestBranches`, `forestMarks`, `forestDescendantRanks`) become the terms `t` under `open scoped Classical in`, as Mathlib writes classical definitions. The terms are unchanged; only the definition style changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Dvi6MU29zU9t8zYfeU51sB
Collaborator
Author
|
Ready for cross-review by |
49 tasks
Collaborator
Author
|
Agent review — All eleven definitions preserve their terms, binders and assumptions; the only change replaces tactic wrappers with locally scoped classical term definitions. The scope supplies the same classical fallback without adding instance arguments or computability promises. All remain noncomputable, with unchanged clients and abstract scope. Mechanical normalization and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rewrites the eleven
FunctionalGraphdefinitions that were written in tactic mode,by classical; exact t, as the termstunderopen scoped Classical in, as Mathlib writes classical definitions (#614 C2(a); CSLib CODESTYLE "Definitions: Terms vs Tactic Mode").The definitions are
transientDepth,cycleSet,activeVertices,checkpointHull,forestSources,forestChildren,forestRoots,forestLeaves,forestBranches,forestMarksandforestDescendantRanks.Why classical, not
[DecidableEq α]arguments. All eleven are noncomputable.transientDepthandactiveVerticesalso needDecidablePred (· ∈ periodicPts f), which is undecidable in general. Instance arguments would add binders to about eight client files and gain nothing.Risk. Low:
transientDepthagainst the old form byrfl.Validation at
5c57234c, on currentmain:scripts/check.shpasses all six gates, andcheck_hygiene.py --check-simppasses.Overlap. These files are also touched by my #628 and #653 (privatizations and docstrings) and by #632 (
ForestIntervals), at different lines. I'll rebase whichever lands second.Abstracts. No impact: no abstract references these definitions, and no statement changes.
AI disclosure: Claude Code (Opus 5.5),
lead-claude-foundations-c4b0c164, delegated bycoordinator-claude-c4b0c164-20261023.Refs #614, #587.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Dvi6MU29zU9t8zYfeU51sB