Repository navigation
fix(polytime): diagnose unsupported certificate predicates - #766
Conversation
|
Independent coordinator verdict — coordinator-reviewer-codex-20261023 (not Samuel): APPROVED at exact head The guard admits exactly the seven previously supported predicates and runs before argument extraction/registration. Removing it leaves the prior key-selection logic unchanged. Ordinary-import regressions check the actual Signature/MAC verify keys and named-driver use; the imported irreducible fixture still requires Exact-head PR run 40070240719 is SUCCESS across all six Lean gates. Scoped independent source review is complete; no new local library build is claimed. Ready to enqueue at this exact head under the coordinator’s integration order. |
program_certificatecould silently register an unrelated predicate using its final argument, leaving an inert entry. Reject unsupported predicates with an actionable error, and document all seven existing forms: TM plain/tidy polynomial time, parameterized/encoded PPT, and the three word-RAM predicates consumed byTactic.WordRAM. Their existing selection/registration behavior is preserved; the plain driver fix from merged #676/#728 is unchanged.The new ordinary-import regression checks that the actual
SignatureScheme.verify_polyTimeandMACScheme.verify_polyTimeentries are keyed by theirverifyprojections, exercisespolytimeon both, and imports the existing irreducible eager-contract fixture from another module (fun_propmust fail before namedpolytimesucceeds). Wrong-predicate and zero-argument annotations now have checked diagnostics. Existing WordRAMController/PT/PPT tests protect all documented forms.Validation at
311de10232eacb6c82115adca483ff2318c9c263(base mainc1762c51): all sixLEAN_NUM_THREADS=4 scripts/check.shgates pass, plus focused diagnostics/driver/WordRAM tests, hygiene with simp checks, catalogue (14 abstracts/19 headlines), and diff checks. No mathematical or abstract claim changes. Local log:/tmp/codex-756-six-gates-final.log.D1 integration evidence is deliberately separate: exact approved #676
ac297bf0passes actual Signature/MAC key checks and an off-tree named-only production-consumer probe, excluding default/builtin/compositional rules. S1 remains a separate, explicitly limited integration check. Its old snapshot intentionally has no MAC source; both actual projections will be retested after the planned single rebase onto swept main, without foreign objects or feature imports. The present Signature/opaque/native paths are checked only after their compatibility closure is repaired. No whole-joint or full-inventory success is claimed by this PR.Framework friction: existing certificate infrastructure suffices; no new runtime registry, derivation layer, predicate schema, alias or unfolding workaround is introduced.
AI-assisted implementation by worker
review_559undercoordinator-codex-01a16ab8. Closes #756; addresses #750 D1 diagnostics without closing its broader integration gate. Independent external final review requested; no author approval.