Repository navigation
refactor(boolean-analysis): move Hypercube and Symmetrization to Foundations/BooleanAnalysis (#610) - #773
Conversation
Independent Pre-PR Review (
|
|
Independent coordinator verdict — coordinator-reviewer-codex-20261023 (not Samuel): APPROVED at exact head I adopt the detailed exact-head independent review 6381288279 and verified the actual relocation diff. Hypercube and Symmetrization are both 100% byte-identical moves into their mathematical Foundations home. Names, namespaces, hypotheses, proofs, attributes, docs and credit are preserved. The four clients and aggregate use the new paths; no old module-path references remain in library, tests, guide or abstracts. Their dependencies remain below the computability/query layer, with no compatibility aliases. No headline-abstract change. Exact-head CI40073069486, job120810505210, is SUCCESS across all six gates and the tidy statement ratchet. This adopts unchanged mathematics; no fresh Huang/symmetrization endpoint audit or local full build is claimed. Ready at this exact head under the coordinator’s integration order. |
|
Integration note ( |
…dations/BooleanAnalysis (#610) Move `Complexity/Computability/QueryComplexity/Sensitivity/Hypercube.lean` to `Complexity/Foundations/BooleanAnalysis/Hypercube.lean` and `Complexity/Computability/QueryComplexity/Symmetrization.lean` to `Complexity/Foundations/BooleanAnalysis/Symmetrization.lean`. Both modules live in `namespace Cslib.BitString` and depend only on `Complexity/Foundations/BooleanAnalysis/`, `Complexity/Foundations/Data/BitString/Weight.lean`, and Mathlib. Co-authored-by: Jetski <jetski@google.com>
|
Rebased onto All 6 |
4e04ab0 to
0e37c3b
Compare
|
Independent coordinator delta verdict — coordinator-reviewer-codex-20261023 (not Samuel): APPROVED at exact head The reviewed feature commit is patch-identical after rebasing onto actual main Exact-head CI40079251256, job120829160711, is SUCCESS across all six Lean gates and the tidy statement ratchet. Ready under the coordinator’s plain-first integration order; preflight the unchanged head before enqueueing. |
Summary
Completes the second slice of #610 item 7 ("Huang's signed adjacency and Minsky–Papert symmetrization:
Cslib.BitString, depends onFourier/LowDegreeandBitString.Weight"):Complexity/Computability/QueryComplexity/Sensitivity/Hypercube.leantoComplexity/Foundations/BooleanAnalysis/Hypercube.lean(100% file rename).Complexity/Computability/QueryComplexity/Symmetrization.leantoComplexity/Foundations/BooleanAnalysis/Symmetrization.lean(100% file rename).Complexity/Computability/QueryComplexity/Huang.lean,Complexity/Computability/QueryComplexity/NisanSzegedy.lean,Complexity/Computability/QueryComplexity/ApproximateDegree/Or.lean, andComplexityTests/QueryComplexity/Approximate.lean) and regeneratesComplexity.lean.Both modules live in
namespace Cslib.BitStringand have zeroComputabilityorQueryComplexitydependencies. All declaration names and namespaces are preserved unchanged.Validation
lake build Complexity ComplexityTests --wfail --iofaillake exe mk_all --checklake exe runLinter Complexity.Foundations.BooleanAnalysis.Hypercube Complexity.Foundations.BooleanAnalysis.Symmetrization Complexity.Computability.QueryComplexity.Huang Complexity.Computability.QueryComplexity.NisanSzegedy Complexity.Computability.QueryComplexity.ApproximateDegree.Or ComplexityTests.QueryComplexity.Approximatelake exe lint-stylepython3 -B scripts/check_hygiene.py --check-simplake exe checkInitImportsAI Disclosure
Authored by
worker-jetski-5950b838(Gemini 3.1 Pro) and independently reviewed pre-PR byreviewer-jetski-610-boolean-analysis(0b8b1371-ecc1-4000-a18a-9fdc8a6a0222) at4e04ab0c6c44a69e139e96d45257e8bf641446b3.Refs #610, #587