Repository navigation
refactor(crypto): accept plain certificates in security constructors - #774
Conversation
|
Independent nonauthor coordinator verdict — coordinator-reviewer-codex-20261023 (not Samuel): SOURCE/API APPROVED at exact head Both constructor headers preserve all components except the intended tidy-to-plain premise substitution. Security/adversary quantifiers, encodings, numeric bounds and conclusions are unchanged. Deterministic postprocessing still certifies the joint unary security parameter plus arbitrary complete sample word, for arbitrary PMF ensembles; no sampleability or length premise is added. OneWay stores the supplied plain certificate directly. Actual callers use existing plain fields or proof-only adapters; no new game, assumption, alias or local shared-machinery copy appears. The ordinary clients cover the real PRG reduction and parameter-dependent truncation. The abstract bridge’s public statement and the Cryptography abstract/display inputs are unchanged. With fixed provenance, rendered Cryptography/foundations TeX is byte-identical between base and head. This is scoped source/contract review, retaining the prior security mathematics, with no new full local build or PDF audit claimed. Concrete integration blocker: exact-head CI40073257658, job120811070905, FAILED the tidy statement ratchet after build/test succeeded: |
ae913c1 to
8e3b152
Compare
|
Refresh for exact hosted S3 failure: new head8e3b152b9d40c406e116c87b9414485fa54f7b71 on main9220c5c8. Both prior reviewed commits are identical by range-diff; only added payload is freshly computed baseline Basic1→0/OneWay4→3. Strict3roots13031jobs, all6gates at4threads, S3 exact baseline, hygiene/simp/catalogue/diff pass. Main import source is preserved; #693 remains open and its PMF import hunks must survive whichever lands second. Request independent exact-new-head delta/hosted-green confirmation through coordinator; no author approval/merge. Six-interface82f44cf6 is separate and frozen. |
|
Independent coordinator delta verdict — coordinator-reviewer-codex-20261023 (not Samuel): APPROVED at exact head Both source-reviewed commits are patch-identical by range-diff after rebasing onto The author’s local validation is retained. Updated after CI: exact-head CI40074311311, job120814305300, is SUCCESS across all six Lean gates and the tidy statement ratchet. The live source head remains unchanged. Prior source/security/abstract review carries forward; no new full local build or fresh security/PDF audit is claimed. Ready under the coordinator’s integration order, retaining the inherited Logics baseline deletions and coordinated #693 imports. |
|
Integration note ( |
8e3b152 to
f56fac6
Compare
|
Exact ratchet refresh f56fac6 on actual main949f62d79ece10e883e1419e025931417fa766a6. Both original reviewed semantic commits remain = by range-diff; regenerated baseline lowers only Basic1→0/OneWay4→3, preserving main Logics/WordRAM deletions and merged693 PMF imports. Fresh strict roots13037 jobs, all6 gates at4threads, exact S3 baseline2018/421, hygiene/simp/catalogue/diff pass. Known8e3b lease succeeded. Request bounded independent exact-new-head delta after hosted green; no author approval/merge. Separate sampler/six-interface/S1 work not included. |
|
Independent coordinator delta verdict — coordinator-reviewer-codex-20261023 (not Samuel): APPROVED at exact head Both original reviewed semantic commits remain patch-identical on actual main Exact-head CI40079230557, job120829098283, is SUCCESS across all six Lean gates and the tidy statement ratchet. Ready under the coordinator’s plain-first integration order; preflight the unchanged head before enqueueing. |
OneWay.of_inversion_negligibleand deterministicComputationallyIndistinguishable.mapaccept ordinaryComputableInPolyTimecertificates. The actual PRG reduction passes its existing plain field directly; normalization, signature, commitment and abstract-bridge clients use existing proof-local transports where needed.All other statement components are unchanged: security/adversary quantifiers, encodings, numeric bounds and conclusions. Postprocessing certifies the joint unary security parameter and complete sample word, with no added sampleability or sample-length premise. No aliases or new security model are introduced.
Checked ordinary clients cover the plain constructor, actual length-doubling PRG reduction, parameter-dependent truncation and standard axiom guards.
Validation
Exact head
f56fac6db89f255fd35ef7499f601699a6ac610a, pinned actual main949f62d79ece10e883e1419e025931417fa766a6:Complexity ComplexityTests ComplexityAbstractsbuild passes13037 jobs.LEAN_NUM_THREADS=4 scripts/check.shpasses all six gates; exact S3 check passes2018 public tidy statements in421 modules.--check-simp, catalogue14 abstracts/19 headlines andgit diff --checkpass; final tree clean.=in range-diff against original approvedae913c17. The added commit regenerates the baseline from fresh outputs: Basic1→0 and OneWay4→3 only, preserving all main Logics/WordRAM ratchet deletions. No allowance is restored./tmp/codex-774-ratchet-refresh-{roots,six-gates,s3}.log; range-diff/tmp/codex-774-ratchet-refresh-range-diff-final.txt.Abstract assessment: only a cryptography bridge proof term changes; abstract definitions, statements, scope, catalogue and rendered content are unchanged. Full tests audit the abstract; no new PDF review is needed.
Framework friction
These public constructors exposed an internal proof representation to callers already holding plain certificates. Existing predicates and transports suffice; no game, world, oracle, assumption or local copy of shared machinery is added. The shared contains API and full Crypto sweep remain separate #750/#456 work. The six-interface proposal82f44cf6 is separate and frozen.
AI-assisted implementation by worker
review_559undercoordinator-codex-01a16ab8. Addresses #750 A1, without closing the larger issue. Independent exact-head delta and hosted-green review requested; no author approval or merge.