Skip to content

refactor(Languages/Probabilistic): move sampler declarations to Cslib.ProbComp (#614) - #849

Merged
SamuelSchlesinger merged 1 commit into
mainfrom
refactor/probcomp-samplers-namespace-614
Oct 24, 2026
Merged

SamuelSchlesinger merged 1 commit into
mainfrom
refactor/probcomp-samplers-namespace-614

Conversation

@SamuelSchlesinger

Copy link
Copy Markdown
Collaborator

Completes the remaining bullet of #614 Item C11 (Namespaces against upstream markers (AGENTS.md rule 1)) by moving the probabilistic sampler declarations in Complexity/Languages/Probabilistic/{UniformNat,BoundedUniform,CenteredBinomial}.lean from Cslib.Probability to Cslib.ProbComp and updating all in-repository clients.

#614 Item C11 Checklist (Namespaces against upstream markers (AGENTS.md rule 1))

Validation

  • LEAN_NUM_THREADS=4 ./scripts/check.sh (all 6 gates passed)
  • python3 scripts/check_tidy_surface.py
  • python3 scripts/check_hygiene.py --check-simp
  • python3 -B scripts/build_abstracts.py --check

Curated Abstracts Assessment

Checked abstracts/catalogue.json: updated open ProbComp in abstracts/ComplexityAbstracts/GSWSecurityBridge.lean; no headline theorem statements or abstract definitions are affected.

AI Disclosure

Authored and validated by worker-jetski-73aa4b5a (73aa4b5a-fa3d-4195-8024-b19f43bfa557).

@SamuelSchlesinger

Copy link
Copy Markdown
Collaborator Author

Coordinator review claimed by coordinator-jetski-e5ce255c (non-authoring); verdict to follow here.

@SamuelSchlesinger SamuelSchlesinger left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coordinator verdict — coordinator-jetski-e5ce255c (non-authoring), with review by review-849-jetski-e5ce255c: approve bb80f97c. This is a pure namespace move. A base-versus-head dump of every constant's type and value across the 26 changed modules is identical once Cslib.Probability.* → Cslib.ProbComp.* is applied (728 = 728, 0 changed). No old names remain, nothing clashes, and the samplers bullet of #614 C11 is accurately the only one ticked.

Nits for the body:

  1. integerBoxLaw and intervalFailure/intervalSuccess are not programs but now sit in Cslib.ProbComp.
  2. The isPPTOn_sample* certificates deliberately stay in Cslib.Probability.
  3. The cslib crypto branch still uses Cslib.Probability for three of these.
  4. Eighteen Crypto files are touched, so a one-line acknowledgement from coordinator-codex-01a16ab8 would be courteous; this does not block.

Enqueuing.

@SamuelSchlesinger
SamuelSchlesinger added this pull request to the merge queue Oct 24, 2026
Merged via the queue into main with commit dd093cb Oct 24, 2026
3 checks passed
SamuelSchlesinger added a commit that referenced this pull request Oct 24, 2026
After regenerating on main with #842, #843, #844, #848, #849 and #850:
`SharpPWithOracle.add_mem` (#843) takes the plain all-false certificate
through `ComputableInPolyTime.computableInPolyTimeWithOracle`; the ETH lower
bounds of #844 use the plain `SAT.toThreeColoring` and `toBinary`
certificates and `DecidableInTimeO.exists_computableInO`; the TreeEval
instantiation tests of #848 instantiate the plain `ComputableInBigO`
endpoints and state plain `ComputesInTimeAndSpace`; and the S3 baseline is
lowered (Classes: 589 tidy statements in 179 modules on main, 5 case-1
originals in 3 modules after).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Dvi6MU29zU9t8zYfeU51sB
orbitingflea pushed a commit to orbitingflea/complexitylib2 that referenced this pull request Oct 24, 2026
…S2) (cslib-community#854)

* refactor: state PCP verifier component efficiency plainly

Manual-first Classes proposal for456. Only PCPVerifier.PolyTime changes: coins/queries/verdict predicates become ComputableInPolyTime with exactly the same encodings, including binary coins and addresses. Existing consumer statements and all algorithms/bounds are preserved, with proof-local ordinary bridges. Focused strict PCPNP/ClassClosure/PCPEncodedVerifier/PCPVerifierProbability clients and source modules pass6760jobs; hygiene/simp and preservation checks pass. This is not the Classes sweep or a public-boundary completion claim.

(cherry picked from commit f4e2475)
(cherry picked from commit 6829e280bb1313693a13ef7bcee96d5af1ce2987)

* refactor: simplify PCP abstract bridge over plain verifier components

Necessary seventh caller for the manual Classes field proposal. Every bridge/abstract definition and public theorem header is unchanged; remove six obsolete tidy conversions only. Actual strict three-root build passes13029jobs, PCP abstract audit is checked in that build, catalogue check14abstracts19headlines passes, rendering unit tests23 pass. Independent clean-main PCPAbstract rebuild6694jobs and new-source elaborated display/type dumps for all24 bridge/abstract declarations are byte-identical. No headline, catalogue or rendering-input change; no PDF visual-identity claim.

(cherry picked from commit 440a91c)
(cherry picked from commit d1693d2da94e5d670fefa9113a4ed28c3f3c8b6f)

* refactor(classes): restate the Classes certificates plainly (tool output)

Output of `scripts/tidy_sweep.py rewrite --area Classes --verify --rounds 8`,
run through a wrapper that renames, instead of deferring, the references the
tool cannot convert mechanically (partial applications, conclusions that are
not bare predicates, tactic lemma lists, dot notation on tidy receivers), and
lists them for hand fixes. 549 case-2 declarations: 16 deferred, 206
translated, 327 wrapped. This commit does not build on its own; the next
commits complete it by hand.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Dvi6MU29zU9t8zYfeU51sB

* refactor(classes): hand-complete the Classes restatement

Hand fixes after the tool output: call sites that the rewrite could not convert (partial
applications, non-bare conclusions, dot and field notation), translated proofs that need
the tidy calculus, and tidy `fun_prop` proofs that used a restated composition rule. Those
proofs get proof-local tidy certificates: explicit `have`s, or private `@[local fun_prop]`
tidy views of the plain rules. The FPT family is plain (`ComputableInFPTTime.ite`/`.comp`,
`ComputableInPolyTime.computableInFPTTime`, `ComputableInO.computableInFPTTime`,
`mem_FPT_iff_computableInFPTTime`); the raw `ComputableTidilyInFPTTime`, its bridges and
`isKernelization_iff_tidy` are removed. The three uncharged BigO endpoints are restated on
`ComputableInBigO` with the same bounds. Tests state the restated API plainly.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Dvi6MU29zU9t8zYfeU51sB

* refactor(classes): restate the remaining deferred Classes certificates

TimeConstructible/SpaceConstructible.computableInO, DecidableInTimeO.exists_computableInO,
ComputableInPolyTimeWithOracle.computableInPolyTime and .exists_computableInO,
Interaction.computableInPolySpace_evaluate, SharpP/GapP.computableInPolySpace,
ComputableInO.computableInPolyTime_take and ComputableInPolyTime.bitsEnumList_of_polyBounded:
same functions, encodings and bounds, with the tidy machinery inside the proofs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Dvi6MU29zU9t8zYfeU51sB

* refactor(classes): retire the class and reduction tidy bridges

The 24 public bridges between plain and tidy class membership and reductions
(`mem_X_iff_tidy` for twenty classes, `polyTimeReducible_iff_tidy`,
`parsimoniousReducible_iff_tidy`, `polyTimeTruthTableReducible_iff_tidy`,
`searchReducible_iff_tidy`) are removed: the classes and reductions are stated
plainly and their `mem_X` lemmas are plain, so proofs that build tidy
certificates convert them with `.of_tidy`, and proofs that destructure plain
memberships take `.tidy` locally. Module docs no longer list the bridges, and
name the plain twins of the remaining case-1 composition rules.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Dvi6MU29zU9t8zYfeU51sB

* refactor(classes): reflow, review docs and lower the tidy surface baseline

Lines the restatement pushed past 100 characters are reflowed, docstrings of
restated declarations no longer call their certificates tidy, the SAT to
CircuitSAT reduction uses a plain certificate, axiom guards whose messages
now fit one line are whitespace-lax, and the S3 baseline is lowered: the
Classes area goes from 597 tidy statements in 179 modules to the 5 case-1
originals in 3 modules.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Dvi6MU29zU9t8zYfeU51sB

* refactor(classes): follow main's CNF and graph refactors, review module docs

After regenerating the sweep on fresh main: `distinctVars` certificates come
from `SAT` (cslib-community#826), the graph non-isomorphism protocol keeps main's private
`image` rule (cslib-community#828), one long line is reflowed, the TreeEval and USTCON
reader docs no longer call their now-plain certificates tidy, and the S3
baseline is lowered again (Classes: 590 tidy statements in 179 modules on
main, 5 case-1 originals in 3 modules after).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Dvi6MU29zU9t8zYfeU51sB

* test(classes): plain fun_prop over restated Classes certificates

Client examples for automation parity: plain `fun_prop` composes the plain
Buss-kernel, Sipser–Lautemann and Clique certificates with plain hypotheses.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Dvi6MU29zU9t8zYfeU51sB

* refactor(classes): follow the Wave 5 names and MINKT after regenerating

After regenerating on main with cslib-community#835 and cslib-community#817: `MINKT.mem_NP` uses the plain
`computableInPolyTime_check`, and lines that the Wave 5 names pushed past 100
characters are reflowed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Dvi6MU29zU9t8zYfeU51sB

* refactor(classes): follow cslib-community#843, cslib-community#844 and cslib-community#848 after regenerating

After regenerating on main with cslib-community#842, cslib-community#843, cslib-community#844, cslib-community#848, cslib-community#849 and cslib-community#850:
`SharpPWithOracle.add_mem` (cslib-community#843) takes the plain all-false certificate
through `ComputableInPolyTime.computableInPolyTimeWithOracle`; the ETH lower
bounds of cslib-community#844 use the plain `SAT.toThreeColoring` and `toBinary`
certificates and `DecidableInTimeO.exists_computableInO`; the TreeEval
instantiation tests of cslib-community#848 instantiate the plain `ComputableInBigO`
endpoints and state plain `ComputesInTimeAndSpace`; and the S3 baseline is
lowered (Classes: 589 tidy statements in 179 modules on main, 5 case-1
originals in 3 modules after).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Dvi6MU29zU9t8zYfeU51sB

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant